From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51993: 29.0.50; [PATCH explanation] Killing emacsclient terminal with `server-stop-automatically' doesn't prompt to save files Date: Fri, 02 Dec 2022 16:31:27 +0200 Message-ID: <83bkolg9mo.fsf@gnu.org> References: <9e47c871-a2c3-d764-bec9-d87abf3efe83@gmail.com> <79a53ecc-dbfc-d088-d80d-96f349be794a@gmail.com> <834k7vw2vb.fsf@gnu.org> <87czc4tosz.fsf@gnus.org> <83lepoi58p.fsf@gnu.org> <83y1tbxbbt.fsf@gnu.org> <83h6zxwujo.fsf@gnu.org> <2738f071-c87f-72cf-226f-6e8597cb07a8@gmail.com> <83a65ouz0e.fsf@gnu.org> <83lenrghhg.fsf@gnu.org> <30673991-caf6-afeb-ec05-d70d6fc45f48@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37686"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 15:33:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p176R-0009aZ-Oj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 15:33:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1769-0008NC-6N; Fri, 02 Dec 2022 09:33:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1766-0008Lk-Uw for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1766-0003zz-Dn for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1766-00066S-1T for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 09:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51993-submit@debbugs.gnu.org id=B51993.166999152323451 (code B ref 51993); Fri, 02 Dec 2022 14:33:02 +0000 Original-Received: (at 51993) by debbugs.gnu.org; 2 Dec 2022 14:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:47058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1759-00066B-2x for submit@debbugs.gnu.org; Fri, 02 Dec 2022 09:32:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1754-00065x-17 for 51993@debbugs.gnu.org; Fri, 02 Dec 2022 09:32:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p174y-0003tW-07; Fri, 02 Dec 2022 09:31:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TPSWbr7toN61ovdCBSgvHTv92W2kyWLhSOgIANh1Fhc=; b=gWfXDSiX1WQ3 pB9kmBE3ts7ATdpnZ5TXSZ9BlftvNqZX2pdmdhW5PnM/hSZHiEvjUrFn/i8lk+UnEujhUZSWg/dlI JzAxUm/YxtmXWUHCQUSmlWmkGz+VKyuIPD2iv0u1Y3gPZu4TZWaNqxmO3cP2TBw0duvmoTl9YMH6O Qol6NBu2ix9/zoCQcgbfb53VhELg2laVRZbyvjb9tGetGqWNgFa+cBlZ/22jys6DURRkANaO8s2yx r33PSbjsBjBH79CX2cSiBgiIsObFyMWFGOvzplJrD2hp3BWtN9J6NicK8Y8WjYRLSkZXYK8ZAmw2Q IKWVSt/X70UAqpR6nigx8g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p174x-0000aO-Ah; Fri, 02 Dec 2022 09:31:51 -0500 In-Reply-To: <30673991-caf6-afeb-ec05-d70d6fc45f48@gmail.com> (message from Jim Porter on Thu, 1 Dec 2022 17:42:18 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249751 Archived-At: > Date: Thu, 1 Dec 2022 17:42:18 -0800 > Cc: larsi@gnus.org, 51993@debbugs.gnu.org, gregory@heytings.org > From: Jim Porter > > Attached is a patch series that explains in more detail how I arrived at > the previous version of my patch. This is basically a reconstruction of > the steps I took when writing it originally. I'll describe my overall > plan and then address the specific comments you had after that. (This > might be overly-verbose, but I wanted to put as much detail in as I > could in the hopes of addressing all your concerns.) Thanks, but unfortunately this methodology doesn't make it easier for me to review the changes. Personally, I'd prefer to have a single place with the logic of what happens when the user closes the last client frame or the last frame on a specific terminal. But I'd like to make progress in this anyway, at least on master. So I'm okay with having your code installed on master as it is, if that is what you prefer.