From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59730: gdb-mi.el: Local variables reordering Date: Wed, 07 Dec 2022 19:50:44 +0200 Message-ID: <83bkof3xxn.fsf@gnu.org> References: <83y1rrgmc3.fsf@gnu.org> <83fsdwcl8u.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59730@debbugs.gnu.org To: Gustaf Waldemarson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 07 18:52:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2yag-0001RO-5m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Dec 2022 18:52:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2yaS-00036O-It; Wed, 07 Dec 2022 12:52:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yaQ-00032O-He for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 12:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2yaQ-0004t3-6r for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 12:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2yaQ-0005Uy-1l for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 12:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2022 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59730 X-GNU-PR-Package: emacs Original-Received: via spool by 59730-submit@debbugs.gnu.org id=B59730.167043546421124 (code B ref 59730); Wed, 07 Dec 2022 17:52:02 +0000 Original-Received: (at 59730) by debbugs.gnu.org; 7 Dec 2022 17:51:04 +0000 Original-Received: from localhost ([127.0.0.1]:51334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2yZU-0005Ue-5e for submit@debbugs.gnu.org; Wed, 07 Dec 2022 12:51:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2yZS-0005Tw-2f for 59730@debbugs.gnu.org; Wed, 07 Dec 2022 12:51:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yZM-0003px-Mb; Wed, 07 Dec 2022 12:50:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ciLlwIlYbu9dSY29/1XpEtSxYY2UTZLOlZ67XFL3MyA=; b=Olh4X4DqmebE VAx6Lv+Y7vFO9D/XhFT1wxOsGDmIh37+c2Hc0n2NOuj9Ks4jLtOgNvQYxaMIEOm7reKjxx/pvhaXw rHTWyMJrYmdcUssn3xuYEmE+1RLkxSMs+UtpKU8d1uP1sAfJwHjH+Wdivm6Q0+L9VUbhp8Q/GXwTc Y8//WQHjNNF4944iGGLwhcGaJJL8O2SVGaqia6a19PMsM0FKdbnAwJqblln7Kdr5h8v7CBI17iVhW vnacPD4VD2Dszuaw4yaOOzzgvZg3TLHgfzEUtVvdrhQKKY7BA+RiBS1OKi8qpwmKCpn/rhHaW7Nit xqr0QhPzqBKBTdpqH7XmvQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yZM-0003rP-5G; Wed, 07 Dec 2022 12:50:56 -0500 In-Reply-To: (message from Gustaf Waldemarson on Sun, 4 Dec 2022 15:26:22 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250204 Archived-At: > From: Gustaf Waldemarson > Date: Sun, 4 Dec 2022 15:26:22 +0100 > Cc: 59730@debbugs.gnu.org > > There I also noticed that that the `gdb-locals-value-limit' > has become redundant with this change. Unfortunately, I wasn't able to figure out how > to mark that defcustom as deprecated, is there some kind of macro that should be done > for that, or should I just remove it? I don't like making backwards-incompatible changes such as removing a user option. How about if the default value of gdb-locals-table-row-config used the value of gdb-locals-value-limit instead of a literal 100? > +** Variable order and truncation can now be configured in gdb-many-window mode. > +The new variable `gdb-locals-table-row-config' allows users to > +configure the order and max length of various properties in the local > +variables frame. ^^^^^ "frame or window", right? > +By default, this variable is set to write the properties in the order: > +name, type and value. Where name and type are truncated to 20 ^^ Our conventions are to use two spaces between sentences. > +characters, and the value is truncated to 100. > + > +In order to restore the old display behavior, set > +`gdb-locals-table-row-config' to '((type . 0)(name . 0)(value . 0)). That value is incorrect, because the value was truncated at 100, due to gdb-locals-value-limit, right? > +Additionally, this behavior encompasses the actions of the old > +`gdb-locals-value-limit' variable, which is no longer used and marked > +deprecated. I hope we won't need this paragraph. Thanks.