From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>, Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 60659@debbugs.gnu.org
Subject: bug#60659: 30.0.50; tree-sitter: identical nodes are not `equal'
Date: Tue, 10 Jan 2023 15:11:20 +0200 [thread overview]
Message-ID: <83bkn6o7pj.fsf@gnu.org> (raw)
In-Reply-To: <1B5F5D8C-8DD3-4ED1-95C2-E975461BC5FC@gmail.com> (message from Yuan Fu on Mon, 9 Jan 2023 21:56:19 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 9 Jan 2023 21:56:19 -0800
> Cc: 60659@debbugs.gnu.org
>
> Eli, does this look right to you? In particular, I’m not sure if it’s ok to call a lisp function (Ftreesit_node_eq) inside internal_equal, even though it never signals.
It is better to make a C function from most of the body of
Ftreesit_node_eq, but without the CHECK_NODE parts, and make both
Fequal and Ftreesit_node_eq call that. Because CHECK_NODE can signal,
right? Also, you should make sure up front that _both_ o1 and o2 are
treesit nodes, otherwise they cannot be 'equal'.
Lars, Stefan: any comments/suggestions?
next prev parent reply other threads:[~2023-01-10 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 14:55 bug#60659: 30.0.50; tree-sitter: identical nodes are not `equal' Mickey Petersen
2023-01-09 3:59 ` Yuan Fu
2023-01-09 8:55 ` Mickey Petersen
2023-01-10 5:56 ` Yuan Fu
2023-01-10 13:11 ` Eli Zaretskii [this message]
2023-01-11 2:57 ` Yuan Fu
2023-01-11 12:26 ` Eli Zaretskii
2023-01-13 1:08 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkn6o7pj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60659@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.