From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 52b67740d10: Generalise a LAP optimisation rule Date: Mon, 03 Apr 2023 20:45:05 +0300 Message-ID: <83bkk4vp0e.fsf@gnu.org> References: <167976134206.19776.1825822435181145052@vcs2.savannah.gnu.org> <20230325162222.64223C1391B@vcs2.savannah.gnu.org> <86ttxw3ltj.fsf@phe.ftfl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, mattiase@acm.org, emacs@FreeBSD.org To: Joseph Mingrone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 03 19:45:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjOF2-00067n-T3 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Apr 2023 19:45:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjOEZ-0007Jv-FW; Mon, 03 Apr 2023 13:44:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjOEY-0007Jg-Pg for emacs-devel@gnu.org; Mon, 03 Apr 2023 13:44:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjOEY-0006FR-3f; Mon, 03 Apr 2023 13:44:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=x1sXvynKEfATBTAG16qNN8zfZRJZu69zzsu/7WGKt6k=; b=Nk3/y/MdExsMb1zpXeHB 88Tz23FyrmQnjj+ak8Nc0mLdJecI0Lho+XKVf3fQMfJMoVQEpsXe7lxgPUONFelUhSyC/Fr/JqRLy V8WOHlJhUI4gXsOUV0fp0AihLrjtlCu4oNXD51TZnN85U75hBD9EPfhsF59MXpd4Z5yYUCPpL/Plh ghWUlqgkGeMoc0PFQB2DPvoqWBwjc3uAIel576k8ZZs9qG5pAkjOEgzuA1FfXYJMtjS9s8JSig+9J aJpELLgDxX9FaFjYXbZoF/CK8RDOy8zpytBK9HuPe10F+Ovn/t2tBUPeXA1oX3F9J4TPJn1U0L9r9 DpHJSa54iTsOlA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjOEX-0005Bf-F2; Mon, 03 Apr 2023 13:44:45 -0400 In-Reply-To: <86ttxw3ltj.fsf@phe.ftfl.ca> (message from Joseph Mingrone on Mon, 03 Apr 2023 14:41:28 -0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305081 Archived-At: > From: Joseph Mingrone > Cc: Mattias Engdegård , emacs@FreeBSD.org > Date: Mon, 03 Apr 2023 14:41:28 -0300 > > On Sat, 2023-03-25 at 12:22, Mattias EngdegÃ¥rd wrote: > > > branch: master > > commit 52b67740d10df8ca539fdc2c7d50283997683141 > > Author: Mattias Engdegård > > Commit: Mattias Engdegård > > > Generalise a LAP optimisation rule > > > * lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode): > > Accept (stack-set 1) as equivalent to (discardN-preserve-tos 1) in a > > rule previously overlooked. This is usually beneficial in code size > > and almost always shortens dynamic paths. > > --- > > lisp/emacs-lisp/byte-opt.el | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el > > index 3c7aeb89525..0891ec80beb 100644 > > --- a/lisp/emacs-lisp/byte-opt.el > > +++ b/lisp/emacs-lisp/byte-opt.el > > @@ -2765,7 +2765,9 @@ If FOR-EFFECT is non-nil, the return value is assumed to be of no importance." > > (or (memq (caar tmp) '(byte-discard byte-discardN)) > > ;; Make sure we don't hoist a discardN-preserve-tos > > ;; that really should be merged or deleted instead. > > - (and (eq (caar tmp) 'byte-discardN-preserve-tos) > > + (and (or (eq (caar tmp) 'byte-discardN-preserve-tos) > > + (and (eq (caar tmp) 'byte-stack-set) > > + (eql (cdar tmp) 1))) > > (let ((next (cadr tmp))) > > (not (or (memq (car next) > > '(byte-discardN-preserve-tos > > Hello, > > This commit causes native compilation builds on FreeBSD to fail with the error > > native-ice ("org/org-plot.el" "block does not end with a branch"... No, that's bug#62481, which is already solved on emacs-29 and the fix should be merged to master soon.