From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval Date: Sat, 15 Jul 2023 12:23:21 +0300 Message-ID: <83bkgdcyuu.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6861"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, philipk@posteo.net, 64543@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 11:24:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKbVp-0001XU-JH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 11:24:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKbVV-0005KJ-6A; Sat, 15 Jul 2023 05:24:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbVS-0005K0-7a for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 05:24:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKbVR-0000QP-WD for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 05:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKbVR-000499-Kq for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 05:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 09:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64543-submit@debbugs.gnu.org id=B64543.168941298915872 (code B ref 64543); Sat, 15 Jul 2023 09:24:01 +0000 Original-Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 09:23:09 +0000 Original-Received: from localhost ([127.0.0.1]:44162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbUb-00047u-HS for submit@debbugs.gnu.org; Sat, 15 Jul 2023 05:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbUY-00047F-Fu for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 05:23:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbUS-0000GW-14; Sat, 15 Jul 2023 05:23:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ciJtstXfvtKUP+sPC1EMieoA5ncQ7pfNNmDIen1YT/g=; b=Xl7uf+W4cpTb CcdyUVSl9d7+1D/AOT8UC4dRlJcXd8a68pps8jNv0CqKJsQmOU0LWLRZ4/yknovQy8zfbNU8JC2MR bCtjX9fbt4smnDm+kEgX+U7KO5iEvuxG51ia4423sjWFKtG+nZAhc9aGt0RmATBjZYnSXfz3xG0+v jESPJO6eTxzj/aFiXqmX5PRkNff0afYQ7Rsj4eUDIJUC8MjRK8AxuoK84p/nQVc2h0drYxrIe+uH5 WMIhiDfpnU0ULT1eXvDJLiQXoHzPC0uYmwK895i1ExgYw1R7AZ6VoQ6qApG09QwaeT3SpU0+VLtOA xkykfnYXaMz6wlH/Rg0klA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbUR-0006ne-HR; Sat, 15 Jul 2023 05:22:59 -0400 In-Reply-To: (message from Spencer Baugh on Sat, 15 Jul 2023 09:12:48 +0000 (UTC)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265179 Archived-At: > Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC) > From: Spencer Baugh > Cc: Philip Kaludercic , sbaugh@janestreet.com, > 64543@debbugs.gnu.org > > On Jul 15, 2023 04:57, Eli Zaretskii wrote: > > > >> Previously we just assumed that the car of an element of > > >> custom-current-group-alist was a filename. But actually it can be nil > > >> if a custom group was defined by just evaling Lisp. > > > > > > Where is this behaviour documented? I couldn't reproduce it with a > > > simple experiment. > > > > To reproduce: > > M-: (defgroup mygroup nil "my group") RET > > > > The patch would ensure that if groups like these are defined (which > > might happen by mistake), then `package-report-bug' will remain robust > > and not fail due to a unrelated issue. > > Is this case important enough to make this change so late in the > pretest? Spencer, how did you bump into this situation in Real Life? > > I evaled a buffer containing a defgroup with C-c C-e (or maybe just a region?) Why did you do that?