From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 22:27:06 +0300 Message-ID: <83bkgb8xo5.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 21:27:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL7Oq-00027W-P2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 21:27:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL7Oa-0006DO-72; Sun, 16 Jul 2023 15:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL7OY-0006BQ-EG for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 15:27:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL7OY-00081O-6k for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 15:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL7OX-0002AX-Ru for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 15:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 19:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.16895356118321 (code B ref 64596); Sun, 16 Jul 2023 19:27:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 19:26:51 +0000 Original-Received: from localhost ([127.0.0.1]:48603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL7ON-0002A9-Hh for submit@debbugs.gnu.org; Sun, 16 Jul 2023 15:26:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL7OL-00029v-07 for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 15:26:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL7OE-00080D-5u; Sun, 16 Jul 2023 15:26:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AMtrYx7FMM516/INED63gKFEJuadvCVYYU2J9xCwfbc=; b=cMDxVrWvCdMI IS278VNvaxh7d53lyO4tYECNVxcZG6TwZ/KR41b366PyB7QLzWZ+E1yPPcULL5TS6/dKYHt8y2C1W 7R1jHiBiGNT4bn9ugsjY7RILgVzJILuZok2sMnSXDuzYJJSjpKikiqR3HpcZtxR4ZisQ+HYYRsbKS xUPMiZ07I6MNmoJAc07JTXLkWjDq+WwOMncKZnPoa7E6ffd5etp58ofFCVYEM6uj6TJ7wtooI0Zgf pnblst+JkbqpeMlbZsGXoY3Gn4vOCJQr8bEpajSi8oZDr9KLz/BluBeiGGPPPpvhlqmqeJKGLz5sq ydSunfFkRaVGp5QVkRYGkA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL7OD-000690-MG; Sun, 16 Jul 2023 15:26:41 -0400 In-Reply-To: <87ttu4gnpt.fsf@localhost> (message from Ihor Radchenko on Sun, 16 Jul 2023 10:22:38 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265361 Archived-At: > From: Ihor Radchenko > Cc: Eli Zaretskii , 64596@debbugs.gnu.org > Date: Sun, 16 Jul 2023 10:22:38 +0000 > > Stefan Monnier writes: > > >> . prevent_redisplay_optimizations_p flag of a buffer > >> . must_be_updated_p flag of a window > > > > No idea what these mean. > > The name `must_be_updated_p` makes it sound to me like it's redundant > > with the `redisplay` flag above. > > I agree about must_be_updated_p. I had exactly same though that it is > redundant with redisplay flag when reading the code. Actually, the must_be_updated_p flag is not for xdisp.c, i.e. not for redisplay_window and its subroutines. It is for update_window, which is the last, 3rd, stage of a redisplay cycle, most of the code of which is in dispnew.c. That's where the newly computed glyph matrix of a window is compared to its current matrix, and Emacs decides what, if anything, should be actually written to the glass. What happens with this flag is that redisplay_window and friends _set_ this flag for windows that dispnew.c _must_ update. The flag is tested in dispnew.c, see there for its use and comments. So it was wrong for me to include that flag in the list which started this sub-thread. Sorry about that.