From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Date: Sat, 05 Aug 2023 16:12:21 +0300 Message-ID: <83bkflskei.fsf@gnu.org> References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> <83y1iqt56g.fsf@gnu.org> <87msz5evo8.fsf@ledu-giraud.fr> <87zg35c00j.fsf@ledu-giraud.fr> <83y1ipst6a.fsf@gnu.org> <87v8dtbq8n.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33951"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65052@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 05 15:13:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSH5o-0008dZ-6g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Aug 2023 15:13:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSH5c-00011F-DH; Sat, 05 Aug 2023 09:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSH5a-00010q-CB for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 09:13:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSH5a-0002Cx-0N for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSH5Z-0005r5-Ri for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 09:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65052 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65052-submit@debbugs.gnu.org id=B65052.169124113422438 (code B ref 65052); Sat, 05 Aug 2023 13:13:01 +0000 Original-Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 13:12:14 +0000 Original-Received: from localhost ([127.0.0.1]:56093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSH4o-0005pp-53 for submit@debbugs.gnu.org; Sat, 05 Aug 2023 09:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSH4m-0005pc-RT for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 09:12:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSH4g-0001vC-Sc; Sat, 05 Aug 2023 09:12:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5t/Y3gAlssTclawHf4syxXo2wlR/Z++c4GSc05Z1CGE=; b=nTXW8PNHpCPj pRIEDQq6HUVOfCwkEePACR2+qE8djLBz+uqwPASwBib00apaNc/IvYGEObuhopyh1uGF1bJSzHXJf zhHofrqLqW7rkPDXcslRHYzU3+6vPPaKLdqJU2QMlhetG3PbvkPeHYCICkOcJk/+5vBwVOsF6Djjw t6PPOeQMtwix0442SuYwqvEu0cLWktiawoHKLkcvqRynQCguPGTTvkWo/9BIbegbBRHekN9GVcujn jfUmT1MOM0isT3WPz4MUS2SXwInNg+6mjW1ck9zb5wLoOvhivudpnI1SlC8QJCkbrN/wSsyMS5XC0 hZ4g+1iGzxNsprVBOPlzug==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSH4g-0006mN-CM; Sat, 05 Aug 2023 09:12:06 -0400 In-Reply-To: <87v8dtbq8n.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 14:58:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266781 Archived-At: > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Sat, 05 Aug 2023 14:58:16 +0200 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Cc: 65052@debbugs.gnu.org > >> Date: Sat, 05 Aug 2023 11:27:08 +0200 > >> > >> >> Hmm... okay, but I wonder why not call image-dired-track-original-file > >> >> and image-dired--update-header-line directly from each of these new > >> >> commands, after scroll-up/down, instead of implementing this as a > >> >> macro (which calls another macro). That would have been much simpler > >> >> and easier to follow. Or is there something I'm missing here? > >> > > >> > Yes it would be much simpler. I was trying to "stay in line" with the > >> > current code. I could try to add the scroll-up/down feature and maybe, > >> > in a later patch, try to remove thoses macros. WDYT? > >> > >> Here. The code is more obvious this way and I think we should do the > >> same for other movements. > > > > Yes, thanks. > > Maybe I should do that into another bug report? It's up to you.