From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] treesit.el: New function to describe font-lock rules Date: Sat, 21 Oct 2023 10:38:33 +0300 Message-ID: <83bkcss9vq.fsf@gnu.org> References: <46a990f4-0cc1-43cb-b017-38e205e05777@gmail.com> <43D13B5A-A267-4181-893E-506D955E973E@gmail.com> <1e5cd9da-7be2-486d-bbbb-7b50167e2916@gmail.com> <35F71E15-AEAB-45FD-ACF3-50133A1766D8@gmail.com> <2c196077-a1c7-4bfa-91b6-209ebf21b6fa@gmail.com> <91640cdb-d78a-4bd5-895c-9aacca3d4c97@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10722"; mail-complaints-to="usenet@ciao.gmane.io" Cc: nguyenthieuhuan@gmail.com, emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 21 09:39:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qu6Zv-0002ah-IE for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Oct 2023 09:39:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu6ZB-0002yf-Vt; Sat, 21 Oct 2023 03:38:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu6Z9-0002yI-TM for emacs-devel@gnu.org; Sat, 21 Oct 2023 03:38:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu6Z9-0005aN-KR; Sat, 21 Oct 2023 03:38:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YkelaugkAo4A4kboiedGCiEdiXlKlD4r0Ufj66nxrik=; b=TmiDhMCEpDF2IgsqrGnz 5lSi03DXkFYTdTCVKywClnYqksXd8j0g2Nk/PKQ0sCrWFta3+4Btq5zPNHlMGvE2mOjiXCl0XgIKE f2SgTTLxU3Ql1cqk6uv4qfXViVnkxB2P4pakyIedZLNA6xVD5jCHN7W5pMRjshEs0+3U746QLSeVX VLxTyZ8g8lV2hKrYgMJpK708/z/vtfpWhPss7uj2xm6CtN1RCLKCZXXxtYxhZbVbY7JYBhsv3Dff8 342xlvxnTgEEepCNbuCNFnb1sA583kwO+dsSM4rLoelBUg1MjqGCpiJYh0VH/oUvK/EQ+0/cZT5n2 MmIdHzmyAabRaQ==; In-Reply-To: (message from Yuan Fu on Fri, 20 Oct 2023 21:11:01 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311638 Archived-At: > From: Yuan Fu > Date: Fri, 20 Oct 2023 21:11:01 -0700 > Cc: emacs-devel , > Eli Zaretskii > > Great! I’ve pushed it to master. Eli, do we need a NEWS entry for this change? We are adding a new keyword for treesit-font-lock-rules. I attached the merged patch below. Not only a NEWS entry is in order, we should also document this keyword in the ELisp manual, where the other keywords of treesit-font-lock-rules are documented. Thanks.