From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67062: 30.0.50; [PATCH] Abbreviate the revision in 'vc-annotate' (for Git) Date: Sun, 12 Nov 2023 13:15:45 +0200 Message-ID: <83bkbzusri.fsf@gnu.org> References: <66fc4912-6aa5-79da-bd6f-52f068cf1a77@gmail.com> <83y1f4wxby.fsf@gnu.org> <2eb31324-ae24-db4b-4f62-a0140bfb9f81@gutov.dev> <83sf5bv77j.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 67062@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 12 12:16:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r28SL-0001Xl-I7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Nov 2023 12:16:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r28S7-00038R-KF; Sun, 12 Nov 2023 06:16:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r28Rz-000385-Bj for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 06:16:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r28Rx-0007nI-JX for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 06:16:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r28Sc-0007gZ-6j for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2023 06:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Nov 2023 11:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67062-submit@debbugs.gnu.org id=B67062.169978781329523 (code B ref 67062); Sun, 12 Nov 2023 11:17:02 +0000 Original-Received: (at 67062) by debbugs.gnu.org; 12 Nov 2023 11:16:53 +0000 Original-Received: from localhost ([127.0.0.1]:55163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r28SS-0007g7-Nn for submit@debbugs.gnu.org; Sun, 12 Nov 2023 06:16:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r28SP-0007fr-Ab for 67062@debbugs.gnu.org; Sun, 12 Nov 2023 06:16:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r28Re-0007V2-S4; Sun, 12 Nov 2023 06:16:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P+efXPD/oYJmppPAA2cdow/oKKYKNLSlyJY/+9FpD88=; b=RMXRAQqXOUdU 49IAZiRGsBnlBIMDFYqdaAXQXIvIz98Ij93DbUM3wG0YIhWXmZ93aXgp5Dzvq5QLXP3HsBVmOWVoM XOZ9sgZdLMmnNguNZ7G2AJPsxmrCpKlTCN1K7Wl7iHhFSyj9xFKtmxZVLDD7VF7UQA7sd7r9FECOK cwfu5T/Flq/lzSS7EZPpXfLYtDl83NkzRSURYVBI8KDRlgqRyRoJdgjGG5vK5qW7Fk2hOuWR7mSzm ITW5HNwP2omKZhzpPsQjYODYqcqeBmZ/BZk5rNcoOEn7jSmgoGhKZMyxbP9Yo2xuco3OD2W7qMjG0 9nmPQDS0nyqqykl5hzDuAg==; In-Reply-To: (message from Dmitry Gutov on Sun, 12 Nov 2023 12:58:06 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274196 Archived-At: > Date: Sun, 12 Nov 2023 12:58:06 +0200 > Cc: jporterbugs@gmail.com, 67062@debbugs.gnu.org > From: Dmitry Gutov > > On 12/11/2023 08:03, Eli Zaretskii wrote: > > I'm not sure I follow. All we need is a new function to call instead > > of vc-working-revision, that's all. That new function will indicate > > the intention to the backend. Sounds easy enough. > > vc-annotate will check (if (eq backend 'Git)) and call a different > function in such case? Rather dirty, but I guess that'll also work. no, vc-annotate will call a new function, which will have a special code for Git alone.