From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Wed, 15 Nov 2023 19:17:59 +0200 Message-ID: <83bkbvq6k8.fsf@gnu.org> References: <87lebcqcof.fsf@posteo.net> <86a5rrcqd3.fsf@mail.linkov.net> <86zfzqeoix.fsf@mail.linkov.net> <86msvobtjm.fsf@mail.linkov.net> <86y1f7cs8l.fsf@mail.linkov.net> <83v8aaxdcy.fsf@gnu.org> <83msvlyczy.fsf@gnu.org> <83sf5cwu01.fsf@gnu.org> <83wmujqh89.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16677"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, juri@linkov.net, dmitry@gutov.dev, joaotavora@gmail.com, 66948-done@debbugs.gnu.org, stefankangas@gmail.com To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 18:19:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3JXh-000474-QL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 18:19:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3JXe-0007MX-61; Wed, 15 Nov 2023 12:19:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3JXc-0007Lw-5w for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 12:19:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3JXb-0002jA-Ju for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 12:19:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3JXa-0006Xq-NA for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 12:19:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 66948@debbugs.gnu.org, eliz@gnu.org, me@eshelyaron.com Original-Received: via spool by 66948-done@debbugs.gnu.org id=D66948.170006869625098 (code D ref 66948); Wed, 15 Nov 2023 17:19:02 +0000 Original-Received: (at 66948-done) by debbugs.gnu.org; 15 Nov 2023 17:18:16 +0000 Original-Received: from localhost ([127.0.0.1]:53491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3JWq-0006Wj-ET for submit@debbugs.gnu.org; Wed, 15 Nov 2023 12:18:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3JWo-0006WX-HM for 66948-done@debbugs.gnu.org; Wed, 15 Nov 2023 12:18:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3JWj-0001Rq-6I; Wed, 15 Nov 2023 12:18:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IH66NY4/c2Lhv/HcsPpzI0ZA6r0gCGek0ui+sIeSx3Y=; b=QpkVTOb3pLZ5 4n0aU7tkYGkKMJ1H5GQwCg1KOKCbDygYW/L2lyYuYx3kN08K0atCOVIBIHTwKxxSxLl1YGJmE0Y09 eG1uJmwnWzh0HssFbFT2SihpN7uxiB6gHDXzMjHnEWh6qXXplcdgyCQTVvUBJ7oMUL1hE/uQjdgL8 aLN9VDQiRBH3Gg+Ai5q0CTfxcpabHsb4JDnIB4IQjrBsDb7uKbTfnoPOJEnPl9pDC6mluwApFY7jU QNHGLvPdR6ARtF66ev+YcksmlVIPS2BfOGCnpKOgZQLOK3B/waN1fEwajo/jq6U3M6g78v091CaXg nb20QRyZXu4MHD6ODtQj7w==; In-Reply-To: (message from Eshel Yaron on Wed, 15 Nov 2023 15:22:25 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274395 Archived-At: > From: Eshel Yaron > Cc: philipk@posteo.net, juri@linkov.net, dmitry@gutov.dev, > stefankangas@gmail.com, 66948@debbugs.gnu.org, joaotavora@gmail.com > Date: Wed, 15 Nov 2023 15:22:25 +0100 > > > How about some color (foreground or background)? > > Sure, I've added a fallback that uses `:weight bold` when that's > supported but `:underline` isn't, and another ultimate fallback that > uses a background color instead. Here's the updated patch (v6): Thanks, installed on master, and closing the bug.