From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Wed, 29 Nov 2023 16:04:03 +0200 Message-ID: <83bkbc7j1o.fsf@gnu.org> References: <87il7ib6cu.fsf@posteo.net> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net> <83il5pbnmh.fsf@gnu.org> <87zfz1cz7s.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34169"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 29 15:05:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8LBZ-0008j7-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Nov 2023 15:05:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8LBS-0001aQ-3L; Wed, 29 Nov 2023 09:04:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8LBP-0001Zm-8i for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 09:04:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8LBO-00053d-Vq for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 09:04:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8LBW-0001xu-Eq for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 09:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Nov 2023 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.17012666727512 (code B ref 66394); Wed, 29 Nov 2023 14:05:02 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 29 Nov 2023 14:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:49184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LB2-0001x5-1W for submit@debbugs.gnu.org; Wed, 29 Nov 2023 09:04:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8LAz-0001wr-R1 for 66394@debbugs.gnu.org; Wed, 29 Nov 2023 09:04:30 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8LAl-0004xC-IK; Wed, 29 Nov 2023 09:04:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3J1hmpHd5QrhsU4i/vFN5W3geexSfylUTWLdzRzbtm0=; b=iPEcyBriXFCSa2hdCKIg 3EibI+dtLkHUBPQghgeqSDOactcDwJdb+mogIyQaZwcbUINKF+iS4A91dCdLe2Z+pCpWbFBxw8ox5 TYsSeAoqA8J86wKg5CfZaMGEk1et6acx3C4MhVOAlVe5kg6aTWDSn9AcBG0pg3I+n+CGJ8ivzfjTa JXhvqidaBkItUH/2tR1qM7h2oZbPZJf9ffiDnU8p2q96DkWHVC8XanjXG+GNdLRuTxqkjxVbQ3QrP lm74MhxM03FQ4pf7QMlCj89mFPqLcj12g/5R6hI0qBQal6bfENhB9pDl47ikfGlUnG7j+D9eon0H7 9CCc4mzrs4Jz6w==; In-Reply-To: <87zfz1cz7s.fsf@posteo.net> (message from Thierry Volpiatto on Sat, 25 Nov 2023 21:14:31 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275230 Archived-At: > From: Thierry Volpiatto > Cc: monnier@iro.umontreal.ca, michael_heerdegen@web.de, > stefankangas@gmail.com, 66394@debbugs.gnu.org > Date: Sat, 25 Nov 2023 21:14:31 +0000 > > Here a patch with the change suggested by Stefan applied, slighly > modified though because it fails if I put the call to > cl--generic-prefill-dispatchers at the recommended place. > > I recompiled Emacs with this patch with no errors. Thanks, installed on master. After this, a test in register-tests.el fails: Running 1 tests (2023-11-29 09:01:59-0500, selector ‘(not (or (tag :unstable) (tag :nativecomp)))’) Point to register: a Test register-test-bug27634 backtrace: signal(ert-test-failed (((should (equal 'quit (condition-case err (c ert-fail(((should (equal 'quit (condition-case err (call-interactive (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de (let (form-description-4) (if (unwind-protect (setq value-2 (apply f (let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti (let* ((fn-0 #'equal) (args-1 (condition-case err (let ((signal-hook (progn (fset 'read-key #'ignore) (let* ((fn-0 #'equal) (args-1 (cond (unwind-protect (progn (fset 'read-key #'ignore) (let* ((fn-0 #'equa (let* ((vnew event) (old (symbol-function 'read-key)) (register-alis (let ((event (car tail))) (let* ((vnew event) (old (symbol-function (while tail (let ((event (car tail))) (let* ((vnew event) (old (symb (let ((tail (list 7 'escape 27))) (while tail (let ((event (car tail (closure (t) nil (let ((tail (list 7 'escape 27))) (while tail (let ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name register-test-bug27634 :documentation ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/register-tests.el" " command-line() normal-top-level() Test register-test-bug27634 condition: (ert-test-failed ((should (equal 'quit (condition-case err ... ...))) :form (equal quit #) :value nil :explanation (different-types quit #))) FAILED 1/1 register-test-bug27634 (1.758961 sec) at lisp/register-tests.el:30 The response "a" to the "Point to register:" question is something I needed to type; previously the test never asked any questions (and it shouldn't, AFAIU). Could you please see if the test suite needs some adaptations to these changes?