From: Eli Zaretskii <eliz@gnu.org>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org,
monnier@iro.umontreal.ca, stefankangas@gmail.com
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Wed, 29 Nov 2023 16:04:03 +0200 [thread overview]
Message-ID: <83bkbc7j1o.fsf@gnu.org> (raw)
In-Reply-To: <87zfz1cz7s.fsf@posteo.net> (message from Thierry Volpiatto on Sat, 25 Nov 2023 21:14:31 +0000)
> From: Thierry Volpiatto <thievol@posteo.net>
> Cc: monnier@iro.umontreal.ca, michael_heerdegen@web.de,
> stefankangas@gmail.com, 66394@debbugs.gnu.org
> Date: Sat, 25 Nov 2023 21:14:31 +0000
>
> Here a patch with the change suggested by Stefan applied, slighly
> modified though because it fails if I put the call to
> cl--generic-prefill-dispatchers at the recommended place.
>
> I recompiled Emacs with this patch with no errors.
Thanks, installed on master.
After this, a test in register-tests.el fails:
Running 1 tests (2023-11-29 09:01:59-0500, selector ‘(not (or (tag :unstable) (tag :nativecomp)))’)
Point to register: a
Test register-test-bug27634 backtrace:
signal(ert-test-failed (((should (equal 'quit (condition-case err (c
ert-fail(((should (equal 'quit (condition-case err (call-interactive
(if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
(let (form-description-4) (if (unwind-protect (setq value-2 (apply f
(let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti
(let* ((fn-0 #'equal) (args-1 (condition-case err (let ((signal-hook
(progn (fset 'read-key #'ignore) (let* ((fn-0 #'equal) (args-1 (cond
(unwind-protect (progn (fset 'read-key #'ignore) (let* ((fn-0 #'equa
(let* ((vnew event) (old (symbol-function 'read-key)) (register-alis
(let ((event (car tail))) (let* ((vnew event) (old (symbol-function
(while tail (let ((event (car tail))) (let* ((vnew event) (old (symb
(let ((tail (list 7 'escape 27))) (while tail (let ((event (car tail
(closure (t) nil (let ((tail (list 7 'escape 27))) (while tail (let
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name register-test-bug27634 :documentation
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/register-tests.el" "
command-line()
normal-top-level()
Test register-test-bug27634 condition:
(ert-test-failed
((should (equal 'quit (condition-case err ... ...))) :form
(equal quit #<marker in no buffer>) :value nil :explanation
(different-types quit #<marker in no buffer>)))
FAILED 1/1 register-test-bug27634 (1.758961 sec) at lisp/register-tests.el:30
The response "a" to the "Point to register:" question is something I
needed to type; previously the test never asked any questions (and it
shouldn't, AFAIU).
Could you please see if the test suite needs some adaptations to these
changes?
next prev parent reply other threads:[~2023-11-29 14:04 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 19:03 bug#66394: 29.1; Make register-read-with-preview more useful Thierry Volpiatto
2023-10-08 6:45 ` bug#66394: [RE] " Thierry Volpiatto
2023-10-12 6:43 ` Thierry Volpiatto
2023-10-14 2:04 ` Richard Stallman
2023-10-14 5:59 ` Thierry Volpiatto
2023-10-16 2:04 ` Richard Stallman
2023-10-15 7:56 ` Thierry Volpiatto
2023-10-15 8:18 ` Stefan Kangas
2023-10-15 10:05 ` Thierry Volpiatto
2023-10-15 12:55 ` Stefan Kangas
2023-11-18 18:39 ` Thierry Volpiatto
2023-10-19 2:42 ` bug#66394: 29.1; " Michael Heerdegen
2023-10-19 6:16 ` Thierry Volpiatto
2023-10-20 5:00 ` Michael Heerdegen
2023-10-20 5:49 ` Thierry Volpiatto
2023-10-21 1:09 ` Michael Heerdegen
2023-10-21 3:34 ` Thierry Volpiatto
2023-10-23 4:09 ` Michael Heerdegen
2023-10-23 5:14 ` Thierry Volpiatto
2023-10-24 3:42 ` Michael Heerdegen
2023-10-24 3:54 ` Michael Heerdegen
2023-10-24 5:30 ` Thierry Volpiatto
2023-10-25 3:54 ` Michael Heerdegen
2023-10-24 7:19 ` Thierry Volpiatto
2023-10-25 4:10 ` Michael Heerdegen
2023-10-25 6:38 ` Thierry Volpiatto
2023-10-26 4:18 ` Michael Heerdegen
2023-10-26 6:17 ` Thierry Volpiatto
2023-10-27 1:27 ` Michael Heerdegen
2023-10-27 4:24 ` Thierry Volpiatto
2023-11-03 4:58 ` Michael Heerdegen
2023-11-19 19:37 ` Thierry Volpiatto
2023-11-20 6:00 ` Thierry Volpiatto
2023-11-20 17:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 18:51 ` Thierry Volpiatto
2023-11-25 10:23 ` Eli Zaretskii
2023-11-25 19:59 ` Thierry Volpiatto
2023-11-25 20:10 ` Eli Zaretskii
2023-11-25 21:14 ` Thierry Volpiatto
2023-11-26 10:38 ` Eli Zaretskii
2023-11-26 16:46 ` Thierry Volpiatto
2023-11-29 14:04 ` Eli Zaretskii [this message]
2023-11-29 18:18 ` Thierry Volpiatto
2023-11-30 6:00 ` Eli Zaretskii
2023-11-30 10:21 ` Thierry Volpiatto
2023-12-02 5:51 ` Thierry Volpiatto
2023-12-02 7:50 ` Eli Zaretskii
2023-12-02 8:08 ` Thierry Volpiatto
2023-12-03 14:35 ` Thierry Volpiatto
2023-12-03 15:05 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 16:48 ` Thierry Volpiatto
2023-12-03 18:29 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 18:39 ` Eli Zaretskii
2023-12-03 21:23 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-04 7:30 ` Thierry Volpiatto
2023-12-04 7:57 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 6:55 ` Thierry Volpiatto
2023-12-11 9:30 ` Thierry Volpiatto
2023-12-11 9:58 ` Thierry Volpiatto
2023-12-11 12:30 ` Eli Zaretskii
2023-12-11 13:10 ` Thierry Volpiatto
2023-12-11 17:32 ` Thierry Volpiatto
2023-12-11 23:36 ` Dmitry Gutov
2023-12-12 6:29 ` Thierry Volpiatto
2023-12-12 9:31 ` Thierry Volpiatto
2023-12-12 10:16 ` Thierry Volpiatto
2023-12-12 16:44 ` Thierry Volpiatto
2023-12-14 1:46 ` Dmitry Gutov
2023-12-14 5:34 ` Thierry Volpiatto
2023-12-14 7:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 8:24 ` Eli Zaretskii
2023-12-14 7:44 ` Eli Zaretskii
2023-12-14 15:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 17:58 ` Thierry Volpiatto
2023-12-14 19:19 ` Andreas Schwab
2023-12-14 20:29 ` Stefan Kangas
2023-12-15 14:45 ` Thierry Volpiatto
2023-12-15 15:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-15 18:36 ` Thierry Volpiatto
2023-12-15 23:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 13:18 ` Thierry Volpiatto
2023-12-16 15:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 20:39 ` Thierry Volpiatto
2023-12-17 23:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 5:15 ` Thierry Volpiatto
2023-12-18 13:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 18:11 ` Thierry Volpiatto
2023-12-18 18:22 ` Dmitry Gutov
2023-12-18 6:18 ` Thierry Volpiatto
2023-12-19 17:40 ` Thierry Volpiatto
2023-12-19 17:47 ` Thierry Volpiatto
2023-12-20 12:05 ` Eli Zaretskii
2023-12-20 17:23 ` Thierry Volpiatto
2023-12-21 11:47 ` Eli Zaretskii
2023-12-21 18:04 ` Thierry Volpiatto
2023-12-23 10:49 ` Eli Zaretskii
2023-12-16 15:07 ` Dmitry Gutov
2023-12-16 20:20 ` Thierry Volpiatto
2023-12-16 23:28 ` Dmitry Gutov
2023-12-14 2:10 ` Dmitry Gutov
2023-12-14 5:30 ` Thierry Volpiatto
2023-12-14 19:39 ` Stefan Kangas
2023-12-12 6:06 ` Alfred M. Szmidt
2023-12-12 9:37 ` Steve Perry via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 12:15 ` Eli Zaretskii
2023-12-12 17:58 ` Steve Perry via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 21:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 9:24 ` Bastien
2023-12-02 9:52 ` Thierry Volpiatto
2023-12-02 10:37 ` Bastien Guerry
2023-12-02 10:54 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 11:55 ` Thierry Volpiatto
2023-12-02 12:43 ` Thierry Volpiatto
2023-12-02 13:02 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 13:50 ` Bastien Guerry
2023-12-02 15:01 ` Thierry Volpiatto
2023-12-05 7:34 ` Tino Calancha
2023-12-05 7:38 ` Tino Calancha
2023-12-05 7:43 ` Tino Calancha
2023-12-12 5:46 ` Pedro Andres Aranda Gutierrez
2023-12-12 12:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bkbc7j1o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66394@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.