From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5703: 23.1.92; `x-show-tip' and `tooltip-frame-parameters' do not respect `left' and `top' Date: Wed, 31 Mar 2010 12:17:19 +0300 Message-ID: <83aatozw80.fsf__8471.96415202252$1270027747$gmane$org@gnu.org> References: <87pr38rnan.fsf@stupidchicken.com> <83pr2mympy.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1270027747 31962 80.91.229.12 (31 Mar 2010 09:29:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 31 Mar 2010 09:29:07 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org, 5703-done@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 31 11:29:01 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NwuEP-0004AX-1S for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Mar 2010 11:29:01 +0200 Original-Received: from localhost ([127.0.0.1]:41328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwuEO-00024y-Ep for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Mar 2010 05:29:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwuBF-0008Ax-Kw for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2010 05:25:45 -0400 Original-Received: from [140.186.70.92] (port=44006 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwuBD-00088A-3J for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2010 05:25:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwuBB-0001vt-FY for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2010 05:25:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47804) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwuBB-0001ve-DD for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2010 05:25:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Nwu3m-0004LW-F0 for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2010 05:18:02 -0400 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Mar 2010 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org Mail-Followup-To: 5703@debbugs.gnu.org, Eli Zaretskii X-GNU-PR-Message: cc-closed 5703 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by 5703-done@debbugs.gnu.org id=D5703.127002706416699 (code D ref 5703); Wed, 31 Mar 2010 09:18:02 +0000 Original-Received: (at 5703-done) by debbugs.gnu.org; 31 Mar 2010 09:17:44 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwu3T-0004LI-ET for submit@debbugs.gnu.org; Wed, 31 Mar 2010 05:17:43 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwu3R-0004LD-4K for 5703-done@debbugs.gnu.org; Wed, 31 Mar 2010 05:17:42 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L0500K002YEGW00@a-mtaout22.012.net.il> for 5703-done@debbugs.gnu.org; Wed, 31 Mar 2010 12:17:11 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.176.135]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0500JNO34LNE30@a-mtaout22.012.net.il>; Wed, 31 Mar 2010 12:17:10 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 31 Mar 2010 05:18:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:35833 Archived-At: > Date: Wed, 31 Mar 2010 08:33:25 +0900 > From: YAMAMOTO Mitsuharu > Cc: Chong Yidong , emacs-devel@gnu.org, > 5703@debbugs.gnu.org, jasonr@gnu.org > > > I see almost identical code in xfns.c versions of these functions, > > so I'd be interested to hear how come the X version does not suffer > > from the same problem. That's because the patch below, although it > > does the job, feels a bit kludgey, and I wonder if there a cleaner > > way. > > Because x_create_tip_frame in xfns.c makes a copy of `parms'? Right, I missed that. Thanks. So I committed to the emacs-23 branch the following patch which fixes the bug: === modified file 'src/ChangeLog' --- src/ChangeLog 2010-03-31 04:00:23 +0000 +++ src/ChangeLog 2010-03-31 09:08:40 +0000 @@ -1,3 +1,8 @@ +2010-03-31 Eli Zaretskii + + * w32fns.c (x_create_tip_frame): Copy `parms' before we modify it + in this function. (Bug#5703) + 2010-03-31 Chong Yidong * nsterm.h: Fix last change. === modified file 'src/w32fns.c' --- src/w32fns.c 2010-01-13 08:35:10 +0000 +++ src/w32fns.c 2010-03-31 09:08:40 +0000 @@ -5427,6 +5427,10 @@ x_create_tip_frame (dpyinfo, parms, text kb = dpyinfo->terminal->kboard; + /* The calls to x_get_arg remove elements from PARMS, so copy it to + avoid destructive changes behind our caller's back. */ + parms = Fcopy_alist (parms); + /* Get the name of the frame to use for resource lookup. */ name = x_get_arg (dpyinfo, parms, Qname, "name", "Name", RES_TYPE_STRING); if (!STRINGP (name)