From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9079: integer overflow etc. issues (e.g., image crashes Emacs) Date: Fri, 15 Jul 2011 08:46:43 +0300 Message-ID: <83aacghz98.fsf@gnu.org> References: <4E1EA0FB.5070903@cs.ucla.edu> <4E1F675E.1020907@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1310708790 27246 80.91.229.12 (15 Jul 2011 05:46:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 15 Jul 2011 05:46:30 +0000 (UTC) Cc: 9079@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 15 07:46:26 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QhbEI-0004wy-4Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2011 07:46:26 +0200 Original-Received: from localhost ([::1]:41505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhbEG-0001VQ-ER for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2011 01:46:24 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhbDy-0001VA-RX for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2011 01:46:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhbDu-0002JY-Na for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2011 01:46:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhbDu-0002JT-Je for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2011 01:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QhbDu-0005qJ-2E; Fri, 15 Jul 2011 01:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2011 05:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9079 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 9079-submit@debbugs.gnu.org id=B9079.131070870522395 (code B ref 9079); Fri, 15 Jul 2011 05:46:02 +0000 Original-Received: (at 9079) by debbugs.gnu.org; 15 Jul 2011 05:45:05 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhbCy-0005p9-Fk for submit@debbugs.gnu.org; Fri, 15 Jul 2011 01:45:04 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhbCw-0005oP-Bf for 9079@debbugs.gnu.org; Fri, 15 Jul 2011 01:45:03 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LOD0060015FVW00@a-mtaout22.012.net.il> for 9079@debbugs.gnu.org; Fri, 15 Jul 2011 08:44:36 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.219.136]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LOD006MW1ACKT30@a-mtaout22.012.net.il>; Fri, 15 Jul 2011 08:44:36 +0300 (IDT) In-reply-to: <4E1F675E.1020907@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 15 Jul 2011 01:46:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49108 Archived-At: > Date: Thu, 14 Jul 2011 15:02:06 -0700 > From: Paul Eggert > CC: 9079@debbugs.gnu.org > > OK, here's an updated version of the bidi.c part of that patch, > reflecting the bidi changes just made to the trunk. Thanks. But why is it a good idea to use ptrdiff_t instead of EMACS_INT? I used EMACS_INT for a reason, not just because I needed a wider type: the bidi cache can never be longer than the longest Lisp string or buffer. So having a cache longer than that is already a bug, and we should announce memory full when a Lisp integer overflows.