From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Sat, 14 Jan 2012 10:59:03 +0200 Message-ID: <83aa5qk6co.fsf@gnu.org> References: <87mx9su32g.fsf@web.de> <87sjjkfvwt.fsf@gmail.com> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> <8762gfnrlj.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1326531630 22753 80.91.229.12 (14 Jan 2012 09:00:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 14 Jan 2012 09:00:30 +0000 (UTC) Cc: 10489@debbugs.gnu.org, michael.albinus@gmx.de, thierry.volpiatto@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 14 10:00:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RlzTN-0001Ak-Bk for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2012 10:00:25 +0100 Original-Received: from localhost ([::1]:42578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlzTM-000825-QA for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jan 2012 04:00:24 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:54234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlzTK-000820-1z for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 04:00:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlzTJ-0002yS-3o for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 04:00:21 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlzTI-0002yJ-W2 for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 04:00:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RlzTx-0005ga-PI for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2012 04:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2012 09:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132653161321804 (code B ref 10489); Sat, 14 Jan 2012 09:01:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 14 Jan 2012 09:00:13 +0000 Original-Received: from localhost ([127.0.0.1]:57061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlzTB-0005fc-2x for submit@debbugs.gnu.org; Sat, 14 Jan 2012 04:00:13 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:35409) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlzT8-0005fS-8h for 10489@debbugs.gnu.org; Sat, 14 Jan 2012 04:00:11 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LXS0090069DGU00@a-mtaout20.012.net.il> for 10489@debbugs.gnu.org; Sat, 14 Jan 2012 10:58:57 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.136.230]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXS009HU6A8GC00@a-mtaout20.012.net.il>; Sat, 14 Jan 2012 10:58:57 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55731 Archived-At: > From: Stefan Monnier > Date: Fri, 13 Jan 2012 20:55:23 -0500 > Cc: 10489@debbugs.gnu.org, Thierry Volpiatto > > >> There's a crucial line missing between the above two. It should clearly > >> document what this function is expected to do. E.g. it should make it > >> clear if (and if so, to what extent) the function is allowed to refer to > >> the actual file system(s) as opposed to only relying on the > >> provided strings. > > If the file name strings are not obviously equal, `file-truename' will > > I don't mean "document what the code currently does" but "document > what the code should do". Same thing in this case. If we want to resolve the various cases of equivalent file names, we have no alternative but hitting the disk. > > "Return non-nil if NAME1 and NAME2 refer to the same file in the file system. > > If either name is not absolute, then it is expanded relative to > > DIR (if given) or `default-directory' for the test." > > That description is too vague: an implementation based on comparing > file-attributes would seem to fit, whereas it's clearly not the semantic > we want to provide. Sorry, I'm not following. Why does a possibly different implementation make the doc string "too vague"? IOW, the doc string _should_ be sufficiently "vague" to allow a change in the implementation without breaking the API or the semantics, right?