From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Thu, 01 Mar 2012 06:03:45 +0200 Message-ID: <83aa41c6hq.fsf@gnu.org> References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <4F428780.8070902@cs.ucla.edu> <4F4D507F.7030008@cs.ucla.edu> <83obshcy8n.fsf@gnu.org> <4F4E7FE0.9040907@cs.ucla.edu> <83d38xcoyt.fsf@gnu.org> <4F4EEE4D.4030706@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1330574530 9666 80.91.229.3 (1 Mar 2012 04:02:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 1 Mar 2012 04:02:10 +0000 (UTC) Cc: ajmr@ilovetortilladepatatas.com, fabrice.popineau@supelec.fr, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 01 05:02:08 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S2xDT-0000Tn-7j for ged-emacs-devel@m.gmane.org; Thu, 01 Mar 2012 05:02:07 +0100 Original-Received: from localhost ([::1]:54791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2xDS-0005l1-BX for ged-emacs-devel@m.gmane.org; Wed, 29 Feb 2012 23:02:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2xDP-0005kY-Cc for emacs-devel@gnu.org; Wed, 29 Feb 2012 23:02:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2xDN-0004dd-8Y for emacs-devel@gnu.org; Wed, 29 Feb 2012 23:02:02 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:43609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2xDN-0004dU-0H for emacs-devel@gnu.org; Wed, 29 Feb 2012 23:02:01 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M0600000TTUYE00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Thu, 01 Mar 2012 06:01:37 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.119.92]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M060006YTUOYG00@a-mtaout21.012.net.il>; Thu, 01 Mar 2012 06:01:37 +0200 (IST) In-reply-to: <4F4EEE4D.4030706@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148847 Archived-At: > Date: Wed, 29 Feb 2012 19:34:37 -0800 > From: Paul Eggert > Cc: fabrice.popineau@supelec.fr, emacs-devel@gnu.org, > ajmr@ilovetortilladepatatas.com > > On 02/29/2012 01:24 PM, Eli Zaretskii wrote: > > I see many changes that qualify existing > > declarations with `const', which cannot possibly be wrong. > > It's not an issue of whether the patch is *wrong*. > It's whether the patch is *needed*. That's not what you originally claimed. You said many changes are to pacify the Microsoft compiler's bogus warnings. There's nothing bogus about using the right data type or declare a variable or an argument `const' when it is. I agree that these changes should go in a separate commit. But then I asked several times to do the same for texinfo.tex when you sync with gnulib, and you declined. So I guess Fabrice is not the only one who does that...