From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12600: 24.2.50; linum-mode: line numbers in fringe do not refresh when resizing frame Date: Thu, 11 Oct 2012 18:56:46 +0200 Message-ID: <83a9vtkkvl.fsf@gnu.org> References: <50720A4F.2010200@gmail.com> <83391p5sjc.fsf@gnu.org> <50729A38.8000800@gmx.at> <83haq53qy8.fsf@gnu.org> <5073F029.4040201@gmx.at> <83y5jfziey.fsf@gnu.org> <50754C80.7010809@gmx.at> <83ehl6z5y0.fsf@gnu.org> <50767172.4060807@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1349974676 13807 80.91.229.3 (11 Oct 2012 16:57:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Oct 2012 16:57:56 +0000 (UTC) Cc: 12600@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 11 18:58:02 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TMM5B-0002yl-N6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2012 18:58:01 +0200 Original-Received: from localhost ([::1]:43010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMM55-0002ye-5h for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2012 12:57:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMM4s-0002ru-RE for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 12:57:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMM4T-0004Tv-I1 for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 12:57:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMM4T-0004Ti-E1 for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 12:57:17 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TMM5C-0007ah-Fx for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2012 12:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Oct 2012 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12600 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12600-submit@debbugs.gnu.org id=B12600.134997465329144 (code B ref 12600); Thu, 11 Oct 2012 16:58:02 +0000 Original-Received: (at 12600) by debbugs.gnu.org; 11 Oct 2012 16:57:33 +0000 Original-Received: from localhost ([127.0.0.1]:39744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TMM4j-0007a0-Aj for submit@debbugs.gnu.org; Thu, 11 Oct 2012 12:57:33 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:39523) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TMM4h-0007Zm-Du for 12600@debbugs.gnu.org; Thu, 11 Oct 2012 12:57:32 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MBQ00900MPKRF00@a-mtaout23.012.net.il> for 12600@debbugs.gnu.org; Thu, 11 Oct 2012 18:56:39 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MBQ009SZN2EMO60@a-mtaout23.012.net.il>; Thu, 11 Oct 2012 18:56:39 +0200 (IST) In-reply-to: <50767172.4060807@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65491 Archived-At: > Date: Thu, 11 Oct 2012 09:12:50 +0200 > From: martin rudalics > CC: cschol2112@gmail.com, 12600@debbugs.gnu.org > > I have no idea what these window structure members (window_end_valid, > last_modified and last_overlay_modified) stand for in practice, who's > supposed to set them, why and when. At least setting window_end_valid > to Qnil in window_resize_apply did not help. But writing > > if (! NILP (update) > /** && ! (! NILP (w->window_end_valid) **/ > /** && w->last_modified >= BUF_MODIFF (b) **/ > /** && w->last_overlay_modified >= BUF_OVERLAY_MODIFF (b)) **/ > && !noninteractive) > > makes the problem disappear. > > So apparently this can be fixed easily but as long as I don't understand > that cryptic conjunct I won't do it. That 'if' is just an optimization: it tries to avoid a (potentially expensive) call to move_it_vertically. It could be expensive with large windows and/or very long lines, for example. So if window-end is not supposed to be called in some inner loop, and we don't mind getting slower on behalf of a package whose design is known to be flawed anyway, we can disable the optimization. Disabling this optimization should never do any harm, AFAIU, except slow down the function.