From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@gnu.org>
Cc: eggert@cs.ucla.edu, 8855@debbugs.gnu.org
Subject: bug#8855: dbus error at startup
Date: Mon, 29 Oct 2012 19:06:56 +0200 [thread overview]
Message-ID: <83a9v58axb.fsf@gnu.org> (raw)
In-Reply-To: <87hapdeilv.fsf@gnu.org>
> From: Chong Yidong <cyd@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, 8855@debbugs.gnu.org
> Date: Mon, 29 Oct 2012 17:24:28 +0800
>
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
> > Attached is a slightly less-intrusive version of the patch.
> > It omits the removal of "#ifdef SIGCHLD", which isn't
> > strictly needed to fix the bug. I don't see any further
> > simplifications, unfortunately. The patch fixes a bug that's
> > been reported multiple times so I'm thinking it may be
> > worthwhile to install now, even though there's a feature
> > freeze.
>
> I think the patch is OK to commit.
I agree.
I also think that after the feature freeze is lifted, it would be good
to refactor the related code so that, e.g., the loop in
process_status_retrieved is joined with the loop(s) in
record_child_status_change. Since we are now asking about a single
process at a time, I don't see why we need a loop inside a loop.
Previous code didn't have this nested-loop structure, AFAICS.
Btw, what about Posix platforms that don't have WNOHANG defined, and
therefore have 'waitpid' redirected to 'wait' -- are they the same
ones which have CAN_HANDLE_MULTIPLE_CHILDREN set to zero? (The cpp
directives don't match.) If some of them don't, then will this new
code work for them with 'wait'?
P.S. Incidentally, the MS-Windows build always had a 'waitpid'-like
implementation of its 'wait' emulation, it just pretended to be
checking all of its child processes, because that's what the mainline
code wanted, but actually always knew which process it should check
for. I guess time is ripe for refactoring that code into an emulation
of 'waitpid'.
P.P.S. We use record_child_status_change in another place as well: in
sysdep.c:wait_for_termination_1. Will the change in the former still
work correctly in the latter (and its callers)?
next prev parent reply other threads:[~2012-10-29 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 17:49 bug#8855: dbus error at startup Dan Nicolaescu
2011-06-26 10:22 ` Michael Albinus
2012-10-25 5:35 ` Paul Eggert
2012-10-25 16:24 ` Eli Zaretskii
2012-10-25 20:57 ` Paul Eggert
2012-10-29 1:38 ` Paul Eggert
2012-10-29 9:24 ` Chong Yidong
2012-10-29 17:06 ` Eli Zaretskii [this message]
2012-10-31 7:36 ` Paul Eggert
2012-10-29 6:27 ` bug#8855: confirmation from glib side Paul Eggert
2012-11-03 18:34 ` bug#8855: installed patch into trunk Paul Eggert
2012-11-27 2:32 ` bug#8855: Fix backported to Emacs 24 Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a9v58axb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=8855@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.