all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14838@debbugs.gnu.org, stephen.berman@gmx.net
Subject: bug#14838: 24.3.50; repeating next-line or previous-line is broken
Date: Fri, 12 Jul 2013 12:48:41 +0300	[thread overview]
Message-ID: <83a9ls5csm.fsf@gnu.org> (raw)
In-Reply-To: <83mwps6dzy.fsf@gnu.org>

> Date: Thu, 11 Jul 2013 23:25:05 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 14838@debbugs.gnu.org
> 
> > From: Stephen Berman <stephen.berman@gmx.net>
> > Cc: jan.h.d@swipnet.se,  14838@debbugs.gnu.org
> > Date: Thu, 11 Jul 2013 22:04:07 +0200
> > 
> > > I don't believe the aref part.  I think the real culprit is font-info.
> > > Let's conduct an experiment: if you modify default-font-height so that
> > > it always just calls frame-char-height, does the problem go away?
> > 
> > Yep, that it does.  And no trace messages are emitted.
> 
> Thanks, I will come up with a change that will refrain from calling
> font-info unless it's strictly necessary.

I'm unsure what test(s) to use to detect reliably the situation where
the font of the default face is different from the frame's default.
The two candidates I thought about are:

  . See if face-remapping-alist is non-nil and includes an association
    for the 'default' face

  . Compare

      (frame-parameter 'font)

    with

      (face-font 'default)

Regarding the 1st candidate, I'm not sure the condition will always
hold whenever the font of the default face was modified in some way.

Regarding the 2nd candidate, I'm not sure (frame-parameter 'font) will
always return a non-trivial value.  Can it return nil, for example?

Any other suggestions?

Stephen, can you test both of the above in your case?

Thanks.





  reply	other threads:[~2013-07-12  9:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 21:29 bug#14838: 24.3.50; repeating next-line or previous-line is broken Stephen Berman
2013-07-11  2:51 ` Eli Zaretskii
2013-07-11 10:04   ` Stephen Berman
2013-07-11 15:59     ` Eli Zaretskii
2013-07-11 18:51       ` Stephen Berman
2013-07-11 19:16         ` Eli Zaretskii
2013-07-11 20:04           ` Stephen Berman
2013-07-11 20:25             ` Eli Zaretskii
2013-07-12  9:48               ` Eli Zaretskii [this message]
2013-07-12 10:19                 ` Stephen Berman
2013-07-12 10:35                   ` Eli Zaretskii
2013-07-13  7:29                   ` Eli Zaretskii
2013-07-13 13:15                     ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a9ls5csm.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=14838@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.