From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] emacs-24 r116828: Revert last commit.
Date: Sat, 22 Mar 2014 17:05:12 +0200
Message-ID: <83a9ci46l3.fsf@gnu.org>
References: <E1WRHHi-0005OC-8T@vcs.savannah.gnu.org>
	<jwvwqfml2aw.fsf-monnier+emacsdiffs@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: plane.gmane.org
X-Trace: ger.gmane.org 1395500723 19221 80.91.229.3 (22 Mar 2014 15:05:23 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sat, 22 Mar 2014 15:05:23 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Stefan <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 22 16:05:31 2014
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1WRNUI-0006E3-Pa
	for ged-emacs-devel@m.gmane.org; Sat, 22 Mar 2014 16:05:30 +0100
Original-Received: from localhost ([::1]:57261 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1WRNUI-0005A8-Bm
	for ged-emacs-devel@m.gmane.org; Sat, 22 Mar 2014 11:05:30 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1WRNU9-0004xs-TO
	for emacs-devel@gnu.org; Sat, 22 Mar 2014 11:05:26 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1WRNU3-00032W-Qn
	for emacs-devel@gnu.org; Sat, 22 Mar 2014 11:05:21 -0400
Original-Received: from mtaout22.012.net.il ([80.179.55.172]:45060)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1WRNU3-00032K-JT
	for emacs-devel@gnu.org; Sat, 22 Mar 2014 11:05:15 -0400
Original-Received: from conversion-daemon.a-mtaout22.012.net.il by
	a-mtaout22.012.net.il (HyperSendmail v2007.08) id
	<0N2U00D00EQ6QN00@a-mtaout22.012.net.il> for
	emacs-devel@gnu.org; Sat, 22 Mar 2014 17:05:14 +0200 (IST)
Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il
	(HyperSendmail v2007.08) with ESMTPA id
	<0N2U00DEEF8PI370@a-mtaout22.012.net.il>;
	Sat, 22 Mar 2014 17:05:14 +0200 (IST)
In-reply-to: <jwvwqfml2aw.fsf-monnier+emacsdiffs@gnu.org>
X-012-Sender: halo1@inter.net.il
X-detected-operating-system: by eggs.gnu.org: Solaris 10
X-Received-From: 80.179.55.172
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:170802
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/170802>

> From: Stefan <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 22 Mar 2014 10:46:44 -0400
> 
> IIUC this revert is not because the commit was done accidentally, right?

Right.  The patch I committed was not ready to go in, it had a bug, or
at least I thought so.

> So if the reversion was done to fix a bug, please remember to put an
> appropriate "Fixes: debbug:NNNN".

The bug was in the commit itself, and that one has no bug number.