From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16434: bug#16694: bugs #16694/#16378: Patches Date: Mon, 28 Apr 2014 19:38:08 +0300 Message-ID: <83a9b5o1e7.fsf@gnu.org> References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> <534517A5.1070306@binary-island.eu> <53492567.4090303@binary-island.eu> <83zjjqsjn7.fsf@gnu.org> <5349546A.4040500@binary-island.eu> <83zjjc82nq.fsf@gnu.org> <53580259.7010508@binary-island.eu> <535CBE43.7000803@binary-island.eu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1398703164 21530 80.91.229.3 (28 Apr 2014 16:39:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2014 16:39:24 +0000 (UTC) Cc: gundaetiapo@gmail.com, 16434@debbugs.gnu.org To: Matthias Dahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 28 18:39:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WeoaL-0001Uc-5O for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2014 18:39:17 +0200 Original-Received: from localhost ([::1]:44975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeoaK-0005YU-Ih for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2014 12:39:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeoaC-0005YL-Ph for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 12:39:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Weoa7-0000in-Hg for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 12:39:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Weoa7-0000ij-E8 for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 12:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Weoa6-0000lJ-Ql for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 12:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Apr 2014 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16434-submit@debbugs.gnu.org id=B16434.13987030962849 (code B ref 16434); Mon, 28 Apr 2014 16:39:02 +0000 Original-Received: (at 16434) by debbugs.gnu.org; 28 Apr 2014 16:38:16 +0000 Original-Received: from localhost ([127.0.0.1]:44054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeoZL-0000js-CL for submit@debbugs.gnu.org; Mon, 28 Apr 2014 12:38:15 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:56810) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeoZF-0000jH-Q8 for 16434@debbugs.gnu.org; Mon, 28 Apr 2014 12:38:11 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N4R006001W6RD00@a-mtaout23.012.net.il> for 16434@debbugs.gnu.org; Mon, 28 Apr 2014 19:38:03 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N4R006DT27ERR00@a-mtaout23.012.net.il>; Mon, 28 Apr 2014 19:38:03 +0300 (IDT) In-reply-to: <535CBE43.7000803@binary-island.eu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88365 Archived-At: > Date: Sun, 27 Apr 2014 10:22:27 +0200 > From: Matthias Dahl > CC: Eli Zaretskii , 16434@debbugs.gnu.org, > gundaetiapo@gmail.com > > Eli, could you please test the attached patches? Everything is rather > self-explanatory and the fix as simplistic as possible. I tested it for > all known possible regressions, but everything works just fine here. It > looks like it is the right thing to do (tm). Unfortunately, I was not > able to test it on win32 (yeah, I know, sorry) for obvious reasons :) > but based on what you said, it should fix the toolbar coloring just fine. Unfortunately, it doesn't fix the problem. It looks like the problem is that when make-face-x-resource-internal is called near the end of face-spec-recalc, inhibit-x-resources is already set non-nil, and so make-face-x-resource-internal does nothing. Don't you see the same problem on X if you set emacs.tool-bar.attributeBackground in the X resources? That would allow you to try the change on your system. > If there are no regressions reported from other parties and if it fixes > the issues on win32, from my side just go ahead and apply it to master > and emacs-24. Btw, in the future, you don't need to submit 2 identical patches, just one to the release branch is enough: it will get merged onto the trunk soon enough after being committed to the branch. Thanks.