From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19084: 24.4; C-x v + should work from the *vc-change-log* buffer Date: Mon, 17 Nov 2014 19:26:06 +0200 Message-ID: <83a93pbuxd.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1416245285 13656 80.91.229.3 (17 Nov 2014 17:28:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Nov 2014 17:28:05 +0000 (UTC) To: 19084@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 17 18:27:58 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XqQ5l-00065g-Sl for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Nov 2014 18:27:58 +0100 Original-Received: from localhost ([::1]:49420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQ5l-0007RX-Fs for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Nov 2014 12:27:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQ53-0006Pm-Hw for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:27:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqQ4t-00053G-Nf for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:27:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQ4t-00053B-Kp for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XqQ4t-0007GL-EP for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:27:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Nov 2014 17:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19084 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.141624520527838 (code B ref -1); Mon, 17 Nov 2014 17:27:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Nov 2014 17:26:45 +0000 Original-Received: from localhost ([127.0.0.1]:36513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqQ4a-0007Ev-ES for submit@debbugs.gnu.org; Mon, 17 Nov 2014 12:26:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44302) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XqQ4Y-0007Ej-2o for submit@debbugs.gnu.org; Mon, 17 Nov 2014 12:26:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqQ4O-0004qf-0d for submit@debbugs.gnu.org; Mon, 17 Nov 2014 12:26:41 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQ4N-0004qb-Tp for submit@debbugs.gnu.org; Mon, 17 Nov 2014 12:26:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQ4G-0005rQ-Ci for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:26:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XqQ48-0004nB-Rk for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:26:24 -0500 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:46607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XqQ48-0004mo-EF for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 12:26:16 -0500 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NF700H0019SGI00@mtaout25.012.net.il> for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 19:21:50 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NF700HMA1KE1J10@mtaout25.012.net.il> for bug-gnu-emacs@gnu.org; Mon, 17 Nov 2014 19:21:50 +0200 (IST) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96166 Right now, it doesn't: emacs -Q C-x v L /some/git-managed/directory/ RET C-x v + => vc-deduce-fileset: Buffer *vc-change-log* is not associated with a file This is less helpful than Emacs could be: the default-directory of the *vc-change-log* buffer is the top-level repository directory. Here's the patch to fix that: --- vc/vc.el~ 2014-03-21 07:34:40.000000000 +0200 +++ vc/vc.el 2014-11-17 19:22:01.358500000 +0200 @@ -985,6 +985,9 @@ (if observer (vc-dired-deduce-fileset) (error "State changing VC operations not supported in `dired-mode'"))) + ((and (derived-mode-p 'log-view-mode) + (setq backend (vc-responsible-backend default-directory))) + (list backend default-directory)) ((setq backend (vc-backend buffer-file-name)) (if state-model-only-files (list backend (list buffer-file-name) OK to commit (with the appropriate log message)? In GNU Emacs 24.4.1 (i686-pc-mingw32) of 2014-10-17 on HOME-C4E4A596F7 Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --prefix=/d/usr' Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Git-Log-View Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Recent input: C-x v L g n g i t / e m t r C-x 1 C-x v + M-x r e p o r t - e m Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... vc-deduce-fileset: Buffer *vc-change-log* is not associated with a file Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils add-log log-view easy-mmode pcvs-util vc-git vc-bzr vc-sccs vc-svn vc-cvs vc-rcs help-mode easymenu vc vc-dispatcher time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) Memory information: ((conses 8 83636 6422) (symbols 32 18627 0) (miscs 32 35 139) (strings 16 15190 3836) (string-bytes 1 376959) (vectors 8 11257) (vector-slots 4 401567 5536) (floats 8 58 271) (intervals 28 556 127) (buffers 508 13))