From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: VC to bind coding-system while invoking Git Date: Fri, 21 Nov 2014 12:29:35 +0200 Message-ID: <83a93k4zjk.fsf@gnu.org> References: <83d28lbwkp.fsf@gnu.org> <87wq6t1zyr.fsf@igel.home> <831tp1bqhk.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1416565810 7454 80.91.229.3 (21 Nov 2014 10:30:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2014 10:30:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: schwab@linux-m68k.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 21 11:30:03 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrlTX-0005Oo-9v for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2014 11:30:03 +0100 Original-Received: from localhost ([::1]:39875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrlTW-0004BF-M2 for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2014 05:30:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrlTE-0004B4-Nb for emacs-devel@gnu.org; Fri, 21 Nov 2014 05:29:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrlT9-0005X0-Br for emacs-devel@gnu.org; Fri, 21 Nov 2014 05:29:44 -0500 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:44344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrlT9-0005Wd-3O for emacs-devel@gnu.org; Fri, 21 Nov 2014 05:29:39 -0500 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NFD00H00WIS5A00@mtaout27.012.net.il> for emacs-devel@gnu.org; Fri, 21 Nov 2014 12:25:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFD00FY5WXPUR20@mtaout27.012.net.il>; Fri, 21 Nov 2014 12:25:01 +0200 (IST) In-reply-to: <831tp1bqhk.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:177932 Archived-At: > Date: Mon, 17 Nov 2014 21:01:59 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > From: Andreas Schwab > > Cc: emacs-devel@gnu.org > > Date: Mon, 17 Nov 2014 18:47:24 +0100 > > > > Eli Zaretskii writes: > > > > > vc-git-command should bind coding-system-for-read/write to the value > > > of vc-git-commits-coding-system (utf-8 by default). Currently, we > > > only do that for a handful of Git commands, which is inconsistent. > > > The result is, for example, that typing RET in a *vc-change-log* > > > buffer might show the non-ASCII characters incorrectly if the default > > > for process-coding-system is not UTF-8. > > > > It should also take i18n.commitEncoding and i18n.logOutputEncoding into > > account. > > Any better way than to run "git config" querying about these 2 before > every git command? I pushed a simple change to emacs-24 that just binds the encoding to vc-git-commits-coding-system. I will work on a more complex solution for the trunk.