From: Eli Zaretskii <eliz@gnu.org>
To: Koichi Arakawa <arakawa@pp.iij4u.or.jp>
Cc: 20264@debbugs.gnu.org
Subject: bug#20264: [PATCH] fix: w32_executable_type() causes a segmentation fault
Date: Mon, 06 Apr 2015 11:02:47 +0300 [thread overview]
Message-ID: <83a8yllm54.fsf@gnu.org> (raw)
In-Reply-To: <20150406.122323.240448317693586769.arakawa@pp.iij4u.or.jp>
> Date: Mon, 06 Apr 2015 12:23:23 +0900 (東京
> (標準時))
> From: Koichi Arakawa <arakawa@pp.iij4u.or.jp>
>
> On Windows platform, w32_executable_type() in src/w32proc.c scans
> 'dllname' in an EXE file. But there are some strange EXE files that
> 'dllname' points to an illegal address, for example, Microsoft's Excel
> (excel.exe) and PowerPoint (POWEPNT.EXE). w32_executable_type() causes
> a segmentation fault for those files.
>
> objdump in binutils seems to know those illegal pointers and discard
> them (pe_print_idata() in bfd/peXXigen.c).
>
> In the following patch, 'dllname' is checked whether it points to the
> valid section's address space and discarded when it's invalid.
Thanks.
> for ( ; imports->Name; imports++)
> {
> char * dllname = RVA_TO_PTR (imports->Name, section,
> executable);
>
> + if (imports->Name < base || dllname >= base + real_size)
> + break;
> +
Shouldn't that "break" be "continue" instead? IOW, shouldn't we try
all the other entries in the DLL import list?
next prev parent reply other threads:[~2015-04-06 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 3:23 bug#20264: [PATCH] fix: w32_executable_type() causes a segmentation fault Koichi Arakawa
2015-04-06 8:02 ` Eli Zaretskii [this message]
2015-04-06 9:48 ` Koichi Arakawa
2015-04-06 10:30 ` Eli Zaretskii
2015-04-06 17:04 ` Koichi Arakawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8yllm54.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20264@debbugs.gnu.org \
--cc=arakawa@pp.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.