From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Proposal: new syntax for eshell-buffer-shorthand (related: bug#19391) Date: Sat, 16 May 2015 10:24:07 +0300 Message-ID: <83a8x5gf3c.fsf@gnu.org> References: <1425543601.2108.0@mail.samertm.com> <87r3qh2pof.fsf@f-box.i-did-not-set--mail-host-address--so-tickle-me> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1431761075 14149 80.91.229.3 (16 May 2015 07:24:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 May 2015 07:24:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Samer Masterson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 16 09:24:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YtWSQ-0001Ju-1J for ged-emacs-devel@m.gmane.org; Sat, 16 May 2015 09:24:26 +0200 Original-Received: from localhost ([::1]:33837 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtWSP-0006rF-EP for ged-emacs-devel@m.gmane.org; Sat, 16 May 2015 03:24:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtWSD-0006r7-Gk for emacs-devel@gnu.org; Sat, 16 May 2015 03:24:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtWSA-0003hs-6Y for emacs-devel@gnu.org; Sat, 16 May 2015 03:24:13 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:39742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtWS9-0003gz-Uj for emacs-devel@gnu.org; Sat, 16 May 2015 03:24:10 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NOF00900LOUSA00@mtaout25.012.net.il> for emacs-devel@gnu.org; Sat, 16 May 2015 10:19:53 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOF003XGLP5ZF50@mtaout25.012.net.il>; Sat, 16 May 2015 10:19:53 +0300 (IDT) In-reply-to: <87r3qh2pof.fsf@f-box.i-did-not-set--mail-host-address--so-tickle-me> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186524 Archived-At: > From: Samer Masterson > Date: Fri, 15 May 2015 19:59:12 -0700 > Cc: Eli Zaretskii > > Thanks for looking at this. Patch below Thanks. It looks like you are using all-SPC indentation, without any TABs, perhaps due to the recent change in .dir-locals.el that caused that. Could you please send the patch in the form equivalent to "diff -w" (I hope Git allows that)? It's hard to read a large patch where most of the lines "changed" just due to whitespace.