all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Samer Masterson <samer@samertm.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Proposal: new syntax for eshell-buffer-shorthand (related:	bug#19391)
Date: Sat, 16 May 2015 10:24:07 +0300	[thread overview]
Message-ID: <83a8x5gf3c.fsf@gnu.org> (raw)
In-Reply-To: <87r3qh2pof.fsf@f-box.i-did-not-set--mail-host-address--so-tickle-me>

> From: Samer Masterson <samer@samertm.com>
> Date: Fri, 15 May 2015 19:59:12 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Thanks for looking at this. Patch below

Thanks.

It looks like you are using all-SPC indentation, without any TABs,
perhaps due to the recent change in .dir-locals.el that caused that.
Could you please send the patch in the form equivalent to "diff -w" (I
hope Git allows that)?  It's hard to read a large patch where most of
the lines "changed" just due to whitespace.



  reply	other threads:[~2015-05-16  7:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  8:20 Proposal: new syntax for eshell-buffer-shorthand (related: bug#19391) Samer Masterson
2015-05-16  2:59 ` [PATCH] " Samer Masterson
2015-05-16  7:24   ` Eli Zaretskii [this message]
2015-05-16  8:05     ` Samer Masterson
2015-05-16  9:00       ` Eli Zaretskii
2015-05-16  9:56         ` Samer Masterson
2015-05-16 13:46           ` Stefan Monnier
2015-05-17 21:34         ` Samer Masterson
2015-05-16 13:45     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a8x5gf3c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=samer@samertm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.