From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Date: Tue, 15 Sep 2015 15:51:16 +0300 Message-ID: <83a8sn977f.fsf@gnu.org> References: <87k2s15sfd.fsf@gnu.org> <83oahc7vxr.fsf@gnu.org> <87lhcgvr1t.fsf@gmx.de> <87r3m4hrfq.fsf@gmx.de> <83fv2jbrkm.fsf@gnu.org> <87zj0rh5lb.fsf@gmx.de> <87h9myt96l.fsf@gmx.de> <87zj0pild7.fsf@gnu.org> <83oah5a35p.fsf@gnu.org> <87vbbdih3w.fsf@gnu.org> <87r3m1igdf.fsf@gnu.org> <837fnt9lup.fsf@gnu.org> <87mvwoycl3.fsf@gmx.de> <83mvwo873t.fsf@gnu.org> <87bnd4xgc5.fsf@gmx.de> <83lhc8852n.fsf@gnu.org> <87zj0nx5i7.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1442323553 28157 80.91.229.3 (15 Sep 2015 13:25:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 13:25:53 +0000 (UTC) Cc: 21432@debbugs.gnu.org, tsdh@gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 15 15:25:42 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbqEW-0002ZX-Eg for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 15:25:16 +0200 Original-Received: from localhost ([::1]:42763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqEV-0004Ck-LE for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 09:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqCc-0008HA-4G for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 09:23:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbpiM-0001cW-0X for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 08:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbpiL-0001cR-U0 for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 08:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbpiL-0002hk-NQ for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 08:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2015 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21432-submit@debbugs.gnu.org id=B21432.144232148010315 (code B ref 21432); Tue, 15 Sep 2015 12:52:01 +0000 Original-Received: (at 21432) by debbugs.gnu.org; 15 Sep 2015 12:51:20 +0000 Original-Received: from localhost ([127.0.0.1]:32822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zbphf-0002gJ-CN for submit@debbugs.gnu.org; Tue, 15 Sep 2015 08:51:19 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:53475) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zbphc-0002g8-QC for 21432@debbugs.gnu.org; Tue, 15 Sep 2015 08:51:17 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NUP00J00Y6VNR00@a-mtaout21.012.net.il> for 21432@debbugs.gnu.org; Tue, 15 Sep 2015 15:51:15 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUP00J5JYDENP10@a-mtaout21.012.net.il>; Tue, 15 Sep 2015 15:51:15 +0300 (IDT) In-reply-to: <87zj0nx5i7.fsf@gmx.de> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106587 Archived-At: > From: Michael Albinus > Cc: tsdh@gnu.org, 21432@debbugs.gnu.org > Date: Tue, 15 Sep 2015 13:54:08 +0200 > > It isn't clear to me why `file-notify--test-event-handler' hasn't > been called for your test file. That must be something in > w32notify.c. What kind of "something"? Notifications do work, and the rest of the tests pass. So it must be something with this particular test. I think the problem is due to the fact that the directory is deleted inside the file-notify--test-with-events form: doing that invalidates the watch, so the events are not reported. If I remove this line from the macro body: (delete-directory temporary-file-directory t) then the notifications are received as expected: Test file-notify-test04-file-validity condition: (ert-test-failed ((should (equal '... (mapcar ... events))) :form (equal (created changed deleted) (created changed)) :value nil :explanation (proper-lists-of-different-length 3 2 (created changed deleted) (created changed) first-mismatch-at 2))) (There's no "deleted" because it's caused by delete-directory call which I removed.) So I modified the test to have the directory deletion outside of the macro, and the test now passes. I also increased the timeout of read-event, because 0.1 was borderline: it sometimes worked and sometimes didn't. Please see if the modified tests work with inotify (they did for me on GNU/Linux).