From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 21432@debbugs.gnu.org, tsdh@gnu.org
Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted
Date: Tue, 15 Sep 2015 15:51:16 +0300 [thread overview]
Message-ID: <83a8sn977f.fsf@gnu.org> (raw)
In-Reply-To: <87zj0nx5i7.fsf@gmx.de>
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: tsdh@gnu.org, 21432@debbugs.gnu.org
> Date: Tue, 15 Sep 2015 13:54:08 +0200
>
> It isn't clear to me why `file-notify--test-event-handler' hasn't
> been called for your test file. That must be something in
> w32notify.c.
What kind of "something"? Notifications do work, and the rest of the
tests pass. So it must be something with this particular test.
I think the problem is due to the fact that the directory is deleted
inside the file-notify--test-with-events form: doing that invalidates
the watch, so the events are not reported. If I remove this line from
the macro body:
(delete-directory temporary-file-directory t)
then the notifications are received as expected:
Test file-notify-test04-file-validity condition:
(ert-test-failed
((should
(equal '...
(mapcar ... events)))
:form
(equal
(created changed deleted)
(created changed))
:value nil :explanation
(proper-lists-of-different-length 3 2
(created changed deleted)
(created changed)
first-mismatch-at 2)))
(There's no "deleted" because it's caused by delete-directory call
which I removed.)
So I modified the test to have the directory deletion outside of the
macro, and the test now passes. I also increased the timeout of
read-event, because 0.1 was borderline: it sometimes worked and
sometimes didn't.
Please see if the modified tests work with inotify (they did for me on
GNU/Linux).
next prev parent reply other threads:[~2015-09-15 12:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 6:36 bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Tassilo Horn
2015-09-08 7:47 ` Michael Albinus
2015-09-08 8:11 ` Tassilo Horn
2015-09-08 15:51 ` Eli Zaretskii
2015-09-08 15:49 ` Eli Zaretskii
2015-09-08 16:01 ` Michael Albinus
2015-09-12 10:18 ` Michael Albinus
2015-09-12 15:11 ` Eli Zaretskii
2015-09-12 18:09 ` Michael Albinus
2015-09-13 19:23 ` Michael Albinus
2015-09-14 6:08 ` Tassilo Horn
2015-09-14 7:08 ` Eli Zaretskii
2015-09-14 7:40 ` Tassilo Horn
2015-09-14 7:56 ` Tassilo Horn
2015-09-14 13:22 ` Eli Zaretskii
2015-09-14 20:23 ` Michael Albinus
2015-09-15 7:38 ` Eli Zaretskii
2015-09-15 8:00 ` Michael Albinus
2015-09-15 8:22 ` Eli Zaretskii
2015-09-15 11:54 ` Michael Albinus
2015-09-15 12:51 ` Eli Zaretskii [this message]
2015-09-15 12:56 ` Michael Albinus
2015-09-16 14:45 ` Michael Albinus
2015-09-16 17:08 ` Eli Zaretskii
2015-09-16 17:26 ` Michael Albinus
2015-09-16 17:55 ` Eli Zaretskii
2015-09-16 18:28 ` Michael Albinus
2015-09-15 5:53 ` Tassilo Horn
2015-09-14 7:35 ` Eli Zaretskii
2015-09-14 7:37 ` Michael Albinus
2015-09-15 13:02 ` Michael Albinus
2015-09-15 13:56 ` Eli Zaretskii
2015-09-16 13:54 ` Michael Albinus
2015-09-20 17:23 ` Michael Albinus
2015-09-20 19:19 ` Eli Zaretskii
2015-09-21 13:40 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8sn977f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21432@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.