From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22534: File notify broken on Windows Date: Sun, 07 Feb 2016 19:46:07 +0200 Message-ID: <83a8ncs9b4.fsf@gnu.org> References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454867244 4574 80.91.229.3 (7 Feb 2016 17:47:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Feb 2016 17:47:24 +0000 (UTC) Cc: 22534@debbugs.gnu.org, michael.albinus@gmx.de To: Fabrice Popineau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 07 18:47:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSTQW-00067q-7U for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Feb 2016 18:47:12 +0100 Original-Received: from localhost ([::1]:36750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTQV-00028P-F4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Feb 2016 12:47:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTQQ-00024i-7E for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 12:47:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSTQM-0000vd-VH for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 12:47:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTQM-0000vX-Rm for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 12:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aSTQM-00026G-NV for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.14548671998023 (code B ref 22534); Sun, 07 Feb 2016 17:47:02 +0000 Original-Received: (at 22534) by debbugs.gnu.org; 7 Feb 2016 17:46:39 +0000 Original-Received: from localhost ([127.0.0.1]:37414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSTPy-00025L-UH for submit@debbugs.gnu.org; Sun, 07 Feb 2016 12:46:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48682) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSTPx-000258-NL for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 12:46:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSTPp-0000gc-Ct for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 12:46:32 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSTPp-0000gY-9I; Sun, 07 Feb 2016 12:46:29 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4098 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aSTPn-0007HR-6f; Sun, 07 Feb 2016 12:46:27 -0500 In-reply-to: (message from Fabrice Popineau on Sun, 7 Feb 2016 14:37:34 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112637 Archived-At: > From: Fabrice Popineau > Date: Sun, 7 Feb 2016 14:37:34 +0100 > Cc: Michael Albinus , 22534@debbugs.gnu.org > > In the 'check for attribute change', I see only 2 'changed' notifications, and not 4 > as expected by the test (around line 512: w32notify does not distinguish between > 'changed' and 'attribute-changed'). > > So I need to apply : > > diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el > index 5fc4ff8..943bd7e 100644 > --- a/test/automated/file-notify-tests.el > +++ b/test/automated/file-notify-tests.el > @@ -507,7 +512,7 @@ file-notify--test-with-events > ;; w32notify does not distinguish between `changed' and > ;; `attribute-changed'. > ((string-equal (file-notify--test-library) "w32notify") > - '(changed changed changed changed)) > + '(changed changed)) > ;; For kqueue and in the remote case, `write-region' > ;; raises also an `attribute-changed' event. > ((or (string-equal (file-notify--test-library) "kqueue") Can you instrument filenotify.el to show the w32notify events this test generates, complete with the corresponding file names? I will then compare to what I see here. > For the rest of this test, whereas the test passes in interactive mode, it fails in batch mode with > several 'deleted' notifications. Namely, I need to apply the following for the test to pass. Does it help to add a call to (read-event nil nil 0.1) after the code that invokes the deletion in each of these cases?