all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#1547: face-font-rescale-alist has no effect
@ 2008-12-12 10:53 Juanma Barranquero
  2008-12-13  3:30 ` Kenichi Handa
  2016-01-07  4:14 ` Andrew Hyatt
  0 siblings, 2 replies; 14+ messages in thread
From: Juanma Barranquero @ 2008-12-12 10:53 UTC (permalink / raw)
  To: Bug-Gnu-Emacs

Package: emacs
Version: 23.0.60
X-Debbugs-CC: handa@m17n.org

[Just a reminder, so the issue is not lost]

Font rescaling is unimplemented in the new font backend.

It was already discussed on the list:

http://lists.gnu.org/archive/html/emacs-devel/2008-06/msg01155.html







^ permalink raw reply	[flat|nested] 14+ messages in thread
* bug#1785: bug#1547: face-font-rescale-alist has no effect
@ 2009-04-17  4:23 Chong Yidong
  0 siblings, 0 replies; 14+ messages in thread
From: Chong Yidong @ 2009-04-17  4:23 UTC (permalink / raw)
  To: Kenichi Handa; +Cc: 1785

> What I currently don't understand is that the font rescaling doesn't
> work for the default font in the above case even after
> (clear-face-cache t).  I'm now investigating the reason.

I think the problem here is that the opened font objects are already
stored in the LFACE_FONT entry of the default face.  Note that

M-: (set-face-attribute 'default nil :font (font-spec)) RET

successfully refreshes the face with the correct rescaling.






^ permalink raw reply	[flat|nested] 14+ messages in thread
* bug#1785: bug#1547: face-font-rescale-alist has no effect
@ 2009-04-18  4:11 Chong Yidong
  2009-04-18 18:14 ` Stefan Monnier
  0 siblings, 1 reply; 14+ messages in thread
From: Chong Yidong @ 2009-04-18  4:11 UTC (permalink / raw)
  To: Kenichi Handa; +Cc: 1785

> > What I currently don't understand is that the font rescaling doesn't
> > work for the default font in the above case even after
> > (clear-face-cache t).  I'm now investigating the reason.
>
> I think the problem here is that the opened font objects are already
> stored in the LFACE_FONT entry of the default face.  Note that
>
> M-: (set-face-attribute 'default nil :font (font-spec)) RET
>
> successfully refreshes the face with the correct rescaling.

Until a better solution comes along, I propose dealing with this
situation with the following hack in startup.el: check to see if the
init file changed face-font-rescale-alist, and reload the default face
if necessary.

What do you think?

*** trunk/lisp/startup.el.~1.527.~	2009-02-20 10:20:55.000000000 -0500
--- trunk/lisp/startup.el	2009-04-18 00:07:05.000000000 -0400
***************
*** 499,505 ****
  		     (delete (concat "PWD=" pwd)
  			     process-environment)))))
      (setq default-directory (abbreviate-file-name default-directory))
!     (let ((menubar-bindings-done nil))
        (unwind-protect
  	  (command-line)
  	;; Do this again, in case .emacs defined more abbreviations.
--- 499,506 ----
  		     (delete (concat "PWD=" pwd)
  			     process-environment)))))
      (setq default-directory (abbreviate-file-name default-directory))
!     (let ((menubar-bindings-done nil)
! 	  (old-face-font-rescale-alist face-font-rescale-alist))
        (unwind-protect
  	  (command-line)
  	;; Do this again, in case .emacs defined more abbreviations.
***************
*** 540,545 ****
--- 541,551 ----
  		  (not (and initial-window-system
  			    (not noninteractive)
  			    (not (eq initial-window-system 'pc)))))
+ 	  ;; If face-font-rescale-alist has changed, reload the
+ 	  ;; default font.
+ 	  (unless (eq face-font-rescale-alist
+ 		      old-face-font-rescale-alist)
+ 	    (set-face-attribute 'default nil :font (font-spec)))
  	  ;; Modify the initial frame based on what .emacs puts into
  	  ;; ...-frame-alist.
  	  (if (fboundp 'frame-notice-user-settings)

Diff finished.  Sat Apr 18 00:07:09 2009






^ permalink raw reply	[flat|nested] 14+ messages in thread
* bug#1785: bug#1547: face-font-rescale-alist has no effect
@ 2009-04-25 14:26 Chong Yidong
  0 siblings, 0 replies; 14+ messages in thread
From: Chong Yidong @ 2009-04-25 14:26 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 1785

I have checked in the work-around for this bug.  A more comprehenssive
fix can wait till after the release.  In the meantime, I'll downgrade
the bug severity to normal.






^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-10-31 17:58 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-12 10:53 bug#1547: face-font-rescale-alist has no effect Juanma Barranquero
2008-12-13  3:30 ` Kenichi Handa
2008-12-14 13:00   ` Juanma Barranquero
2008-12-16 11:33     ` Kenichi Handa
2019-10-31 17:58   ` bug#1785: " Lars Ingebrigtsen
2016-01-07  4:14 ` Andrew Hyatt
2016-07-09 19:40   ` npostavs
2016-07-14  4:04     ` Andrew Hyatt
2016-07-14 15:08       ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2009-04-17  4:23 Chong Yidong
2009-04-18  4:11 Chong Yidong
2009-04-18 18:14 ` Stefan Monnier
2009-04-22 14:04   ` Chong Yidong
2009-04-25 14:26 Chong Yidong

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.