From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Thu, 21 Jul 2016 17:26:15 +0300 Message-ID: <83a8hbysmw.fsf@gnu.org> References: <87vb066ejv.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <83shv4z7e8.fsf@gnu.org> <83inw0yw9q.fsf@gnu.org> <87bn1rdd1f.fsf@users.sourceforge.net> <83h9bjzp5i.fsf@gnu.org> <877fcfd79w.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469111249 12237 80.91.229.3 (21 Jul 2016 14:27:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 14:27:29 +0000 (UTC) Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 21 16:27:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQEwW-0006io-8d for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 16:27:16 +0200 Original-Received: from localhost ([::1]:41147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQEwV-0007hi-9D for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 10:27:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQEwM-0007fe-QL for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 10:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQEwI-0002B0-Lw for bug-gnu-emacs@gnu.org; Thu, 21 Jul 2016 10:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQEwI-0002Ap-Io; Thu, 21 Jul 2016 10:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQEwI-0000Jh-Bu; Thu, 21 Jul 2016 10:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Thu, 21 Jul 2016 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.14691111981187 (code B ref 23917); Thu, 21 Jul 2016 14:27:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 21 Jul 2016 14:26:38 +0000 Original-Received: from localhost ([127.0.0.1]:60554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQEvq-0000J2-Iv for submit@debbugs.gnu.org; Thu, 21 Jul 2016 10:26:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQEvl-0000Im-NA for 23917@debbugs.gnu.org; Thu, 21 Jul 2016 10:26:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQEvd-00022W-DH for 23917@debbugs.gnu.org; Thu, 21 Jul 2016 10:26:24 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQEvT-00020Q-Jo; Thu, 21 Jul 2016 10:26:11 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQEvR-0006yv-Ek; Thu, 21 Jul 2016 10:26:09 -0400 In-reply-to: <877fcfd79w.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121386 Archived-At: > From: npostavs@users.sourceforge.net > Cc: 23917@debbugs.gnu.org, nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, monnier@iro.umontreal.ca, alex.bennee@linaro.org > Date: Wed, 20 Jul 2016 23:00:59 -0400 > > > Please also make sure bug#23869 is still fixed after this. > > Following the recipe in > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23869#11 gives me 'Lisp > error: (error "Match data clobbered by buffer modification hooks")', > that indicates it's still fixed, right? Yes, but I thought we want to remove the error-out code. Since we now protect ourselves from clobbered data, we don't need that extra protection, and I think leaving it in place will cause false positives (as a few people already reported). That's because the adjustment of the search registers in the new function you introduce will itself trigger the error message, won't it? Perhaps we should error out only if the number of registers changed, because that can never be valid, I think.