From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch Date: Sat, 08 Oct 2016 18:57:32 +0300 Message-ID: <83a8eehlzn.fsf@gnu.org> References: <20161008093643.10907.90387@vcs.savannah.gnu.org> <20161008093643.BC95522015F@vcs.savannah.gnu.org> <83h98mhpci.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475942272 30350 195.159.176.226 (8 Oct 2016 15:57:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Oct 2016 15:57:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 08 17:57:47 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsu0J-0006N1-Ta for ged-emacs-devel@m.gmane.org; Sat, 08 Oct 2016 17:57:40 +0200 Original-Received: from localhost ([::1]:41567 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsu0I-00012p-EE for ged-emacs-devel@m.gmane.org; Sat, 08 Oct 2016 11:57:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsu0B-00012g-5f for emacs-devel@gnu.org; Sat, 08 Oct 2016 11:57:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsu07-00037T-VC for emacs-devel@gnu.org; Sat, 08 Oct 2016 11:57:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsu07-00036C-T2; Sat, 08 Oct 2016 11:57:27 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2960 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bsu05-0003hb-Q5; Sat, 08 Oct 2016 11:57:26 -0400 In-reply-to: (message from Stefan Monnier on Sat, 08 Oct 2016 11:43:11 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208105 Archived-At: > From: Stefan Monnier > Date: Sat, 08 Oct 2016 11:43:11 -0400 > > >> > * lisp/isearch.el (isearch-update): Compute the window's body > >> > width in a way that is correct when there are no fringes. > >> > (Bug#24584) > >> [...] > >> > - (>= (car visible-p) (window-body-width nil t))) > >> > + (>= (car visible-p) > >> > + (* (window-max-chars-per-line) (frame-char-width)))) > >> > >> Hmm... shouldn't window-body-width return the right answer even when > >> there are no fringes? > > We were too afraid to make that change at the time, because some > > callers don't (or might not) want that. > > Ah, so this is only for the emacs-25 branch, and on master we'll have > "the right fix" instead? Not necessarily, see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22891#59 Volunteers are welcome to review the users of window-body-width and suggest which ones to convert.