From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch
Date: Sat, 08 Oct 2016 18:57:32 +0300 [thread overview]
Message-ID: <83a8eehlzn.fsf@gnu.org> (raw)
In-Reply-To: <jwvzimex2xt.fsf-monnier+gmane.emacs.devel@gnu.org> (message from Stefan Monnier on Sat, 08 Oct 2016 11:43:11 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat, 08 Oct 2016 11:43:11 -0400
>
> >> > * lisp/isearch.el (isearch-update): Compute the window's body
> >> > width in a way that is correct when there are no fringes.
> >> > (Bug#24584)
> >> [...]
> >> > - (>= (car visible-p) (window-body-width nil t)))
> >> > + (>= (car visible-p)
> >> > + (* (window-max-chars-per-line) (frame-char-width))))
> >>
> >> Hmm... shouldn't window-body-width return the right answer even when
> >> there are no fringes?
> > We were too afraid to make that change at the time, because some
> > callers don't (or might not) want that.
>
> Ah, so this is only for the emacs-25 branch, and on master we'll have
> "the right fix" instead?
Not necessarily, see
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22891#59
Volunteers are welcome to review the users of window-body-width and
suggest which ones to convert.
prev parent reply other threads:[~2016-10-08 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161008093643.10907.90387@vcs.savannah.gnu.org>
[not found] ` <20161008093643.BC95522015F@vcs.savannah.gnu.org>
2016-10-08 14:26 ` [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch Stefan Monnier
2016-10-08 14:45 ` Eli Zaretskii
2016-10-08 15:43 ` Stefan Monnier
2016-10-08 15:57 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a8eehlzn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.