all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: npostavs@users.sourceforge.net
Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Wed, 30 Nov 2016 17:55:17 +0200	[thread overview]
Message-ID: <83a8chq7x6.fsf@gnu.org> (raw)
In-Reply-To: <87wpflhgsf.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net)

> From: npostavs@users.sourceforge.net
> Cc: Eli Zaretskii <eliz@gnu.org>,  25025@debbugs.gnu.org
> Date: Tue, 29 Nov 2016 20:56:16 -0500
> 
> Clément Pit--Claudel <clement.pit@gmail.com> writes:
> 
> > On 2016-11-29 19:36, npostavs@users.sourceforge.net wrote:
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> 
> >>>> From: npostavs@users.sourceforge.net
> >>>> Cc: 25025@debbugs.gnu.org,  clement.pit@gmail.com
> >>>> Date: Sun, 27 Nov 2016 11:06:03 -0500
> >>>>
> >>>>> Why does it need to be split?  A shell command can (even should) be
> >>>>> handed to the shell as a single string.
> >>>>
> >>>> Currently it's not a shell command, because a shell isn't being used.
> >>>> My other suggestion was to use a shell:
> >>>>
> >>>>>> It might be more intuitive to actually use a shell and then the user
> >>>>>> would enter a shell command (though inserting a shell into things
> >>>>>> might bring more complications).
> >>>
> >>> If it doesn't use a shell, then it has no business quoting commands or
> >>> their parts using shell-related APIs.
> >>>
> >>> So yes, I think using a shell would be TRT here.  Can someone please
> >>> work on a patch in that direction?  This problem exists for a long
> >>> time, so I hope we could solve it soon.
> >> 
> >> Hmm, the difficulty in using a shell is that the current code wants to
> >> parse the command into interpreter and arguments in order to match
> >> against `python-shell-completion-native-disabled-interpreters'.
> >
> > That doesn't prevent us from using a shell.  We run the command
> > unmodified through a shell, and we split it and analyze it separately
> > to decide whether to enable completion.  But we don't split and
> > reassemble it before running it.
> 
> Yes, but then we need to parse a shell quoted command, which is quite a
> bit more difficult.  That gets back to your suggestion about getting an
> elisp equivalent to shlex I suppose.
> 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25025#28

Confused: how does python-shell-completion-native-disabled-interpreters
get into this picture?  The function which uses it,
python-shell-completion-native-interpreter-disabled-p, looks at
python-shell-interpreter, which isn't affected by quoting or by how
the command is treated.  What am I missing?





  reply	other threads:[~2016-11-30 15:55 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  6:24 bug#25025: python-shell-calculate-command is wrong Fabrice Popineau
2016-11-25  7:03 ` Clément Pit--Claudel
2016-11-25  8:32   ` Eli Zaretskii
2016-11-25 14:44     ` Clément Pit--Claudel
2016-11-25 14:59     ` Noam Postavsky
2016-11-26 18:43       ` Eli Zaretskii
2016-11-27  0:50         ` Noam Postavsky
2016-11-27  2:35           ` Clément Pit--Claudel
2016-11-27 15:56           ` Eli Zaretskii
2016-11-27 16:06             ` npostavs
2016-11-27 16:12               ` Eli Zaretskii
2016-11-28  8:42                 ` Andreas Röhler
2016-11-28 14:15                   ` npostavs
2016-11-28 16:43                     ` Andreas Röhler
2016-11-30  0:39                       ` npostavs
2016-11-30  6:39                         ` Andreas Röhler
2016-11-30 17:12                           ` Clément Pit--Claudel
2016-11-30  0:36                 ` npostavs
2016-11-30  1:35                   ` Clément Pit--Claudel
2016-11-30  1:56                     ` npostavs
2016-11-30 15:55                       ` Eli Zaretskii [this message]
2016-11-30 22:10                         ` Noam Postavsky
2016-12-01 17:10                           ` Eli Zaretskii
2016-12-02  1:12                             ` npostavs
2016-12-02  7:35                               ` Eli Zaretskii
2016-12-02 14:16                                 ` Noam Postavsky
2016-12-02 14:51                                   ` Eli Zaretskii
2016-12-02 15:07                                     ` npostavs
2016-12-02 15:46                                       ` Eli Zaretskii
2016-12-02 16:15                                 ` Clément Pit--Claudel
2016-12-02 16:41                                   ` Noam Postavsky
2016-12-02 16:58                                     ` Clément Pit--Claudel
2016-12-09  5:29                                     ` npostavs
2017-08-16 11:08                                       ` npostavs
2017-08-16 14:32                                         ` Eli Zaretskii
2017-08-16 16:50                                           ` Noam Postavsky
2017-08-16 16:57                                             ` Eli Zaretskii
2017-08-16 19:27                                               ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a8chq7x6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25025@debbugs.gnu.org \
    --cc=clement.pit@gmail.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.