From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25230: Patch to ispell.el to simplify use of [:alpha:] for CASECHARS in built-in dictionaries Date: Wed, 21 Dec 2016 19:15:27 +0200 Message-ID: <83a8bp2ogg.fsf@gnu.org> References: <831sx36g75.fsf@gnu.org> <837f6u4nmx.fsf@gnu.org> <83eg122xzf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1482340638 18904 195.159.176.226 (21 Dec 2016 17:17:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2016 17:17:18 +0000 (UTC) Cc: 25230@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 21 18:17:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJkVr-0004CP-V5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Dec 2016 18:17:12 +0100 Original-Received: from localhost ([::1]:58161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJkVw-0001mP-Bi for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Dec 2016 12:17:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJkVn-0001l3-Hz for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:17:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJkVi-00040c-NH for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:17:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJkVi-00040N-KE for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cJkVi-0001HW-Fn for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2016 12:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2016 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25230-submit@debbugs.gnu.org id=B25230.14823405784868 (code B ref 25230); Wed, 21 Dec 2016 17:17:02 +0000 Original-Received: (at 25230) by debbugs.gnu.org; 21 Dec 2016 17:16:18 +0000 Original-Received: from localhost ([127.0.0.1]:50446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJkV0-0001GR-HN for submit@debbugs.gnu.org; Wed, 21 Dec 2016 12:16:18 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJkUz-0001GE-5F for 25230@debbugs.gnu.org; Wed, 21 Dec 2016 12:16:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJkUq-0003NY-VE for 25230@debbugs.gnu.org; Wed, 21 Dec 2016 12:16:12 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJkUq-0003NU-RX; Wed, 21 Dec 2016 12:16:08 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4168 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cJkUn-0004ug-Hr; Wed, 21 Dec 2016 12:16:08 -0500 In-reply-to: (message from Reuben Thomas on Wed, 21 Dec 2016 00:20:27 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127294 Archived-At: > From: Reuben Thomas > Date: Wed, 21 Dec 2016 00:20:27 +0000 > Cc: 25230@debbugs.gnu.org > > Here's an updated patch, which simply removes the overriding of the built-in > CASECHARS/NOT-CASECHARS settings for ispell dictionaries. It assumes that all other dictionaries (either > configured by the user or found by the various auto-scanning functions) will have sensible > CASECHARS/NOT-CASECHARS values, which is expected to be the case at present. Looks like you sent the wrong patch, as this: > diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el > index 23ee412..82e5c2b 100644 > --- a/lisp/textmodes/ispell.el > +++ b/lisp/textmodes/ispell.el > @@ -436,114 +436,70 @@ ispell-dictionary-base-alist > ;; The default dictionary. It may be English.aff, or any other > ;; dictionary depending on locale and such things. We should probably > ;; ask ispell what dictionary it's using, but until we do that, let's > - ;; just use a minimal regexp. [:alpha:] will later be set if possible. > - "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1) > + ;; just use a minimal regexp. > + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1) > ("american" ; Yankee English > - "[A-Za-z]" "[^A-Za-z]" "[']" nil ("-B") nil iso-8859-1) > + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil ("-B") nil iso-8859-1) > ("brasileiro" ; Brazilian mode > - "[A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]" > - "[^A-Z\301\311\315\323\332\300\310\314\322\331\303\325\307\334\302\312\324a-z\341\351\355\363\372\340\350\354\362\371\343\365\347\374\342\352\364]" > - "[']" nil nil nil iso-8859-1) > + "[[:alpha:]]" "[^[:alpha:]]" "[']" nil nil nil iso-8859-1) leaves the overriding in place. Am I missing something?