all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: emacs-devel@gnu.org
Subject: Re: correct way to install a bug fix?
Date: Fri, 13 Jan 2017 10:46:49 +0200	[thread overview]
Message-ID: <83a8avcpom.fsf@gnu.org> (raw)
In-Reply-To: <87eg074e9q.fsf@tromey.com> (message from Tom Tromey on Fri, 13 Jan 2017 00:20:33 -0700)

> From: Tom Tromey <tom@tromey.com>
> Date: Fri, 13 Jan 2017 00:20:33 -0700
> 
> On the one hand, admin/notes/git-workflow seems to advise pushing to
> master and then cherry-picking to the release branch, adding "Backport:"
> to the commit message.
> 
> On the other hand, admin/notes/repo says that fixes should be installed
> on the release branch and then someone will sync them to master; and it
> says that installing manually on more than one branch is bad.
> 
> Which should I do?

In general, the latter.  (git-workflow only says what you cite under
"Backporting", which describes a situation where a commit pushed to
master is later regarded as appropriate for the release branch, which
is not your use case.)

However, we are very close to releasing Emacs 25.2 from the release
branch, so currently the release branch is is only open for changes
that fit one of the following criteria:

  . documentation changes
  . fixes for bugs that were introduced by Emacs 25.1
  . very safe fixes for bugs introduced in v24.5

If your bugfixes don't fit any of these, please push to master.

Thanks.



      reply	other threads:[~2017-01-13  8:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  7:20 correct way to install a bug fix? Tom Tromey
2017-01-13  8:46 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a8avcpom.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.