From: Eli Zaretskii <eliz@gnu.org>
To: stephen.berman@gmx.net
Cc: 27008@debbugs.gnu.org
Subject: bug#27008: 26.0.50; auto-hscroll-mode and scroll-left
Date: Tue, 30 May 2017 20:31:38 +0300 [thread overview]
Message-ID: <83a85udzet.fsf@gnu.org> (raw)
In-Reply-To: <83bmqae00s.fsf@gnu.org> (message from Eli Zaretskii on Tue, 30 May 2017 20:18:27 +0300)
> Date: Tue, 30 May 2017 20:18:27 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 27008@debbugs.gnu.org
>
> > From: Stephen Berman <stephen.berman@gmx.net>
> > Cc: 27008@debbugs.gnu.org
> > Date: Tue, 30 May 2017 18:57:01 +0200
> >
> > Thanks very much for pursuing this. I updated my master branch, applied
> > your patch and rebuilt, but when I executed the recipe of my OP, I saw
> > the same effect with the patch as without it: only the current line
> > respects w->min_hscroll, the other are displayed from BOL. I'd be happy
> > to try and help diagnose this further, if you can advise me what to do.
>
> I don't have any advice, because your recipe worked for me after the
> changes. I'm confused now.
Ah, I see: I sent the wrong patch. Here's the right one:
diff --git a/src/xdisp.c b/src/xdisp.c
index ddb26b8..3ccd035 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -2890,8 +2890,19 @@ init_iterator (struct it *it, struct window *w,
}
else
{
+ /* When hscrolling only the current line, don't apply the
+ hscroll here, it will be applied by display_line when it gets
+ to laying out the line showing point. However, if the
+ window's min_hscroll is positive, the user specified a lower
+ bound for automatic hscrolling, so they expect the
+ non-current lines to obey that hscroll amount. */
if (hscrolling_current_line_p (w))
- it->first_visible_x = 0;
+ {
+ if (w->min_hscroll > 0)
+ it->first_visible_x = w->min_hscroll * FRAME_COLUMN_WIDTH (it->f);
+ else
+ it->first_visible_x = 0;
+ }
else
it->first_visible_x =
window_hscroll_limited (w, it->f) * FRAME_COLUMN_WIDTH (it->f);
next prev parent reply other threads:[~2017-05-30 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 14:10 bug#27008: 26.0.50; auto-hscroll-mode and scroll-left Stephen Berman
2017-05-21 15:23 ` Eli Zaretskii
2017-05-21 20:12 ` Stephen Berman
2017-05-30 14:56 ` Eli Zaretskii
2017-05-30 16:57 ` Stephen Berman
2017-05-30 17:18 ` Eli Zaretskii
2017-05-30 17:31 ` Eli Zaretskii [this message]
2017-05-30 19:45 ` Stephen Berman
2017-05-31 7:14 ` Eli Zaretskii
2017-05-31 14:18 ` Stephen Berman
2017-05-31 14:39 ` Eli Zaretskii
2017-05-31 16:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a85udzet.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27008@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.