From: Eli Zaretskii <eliz@gnu.org>
To: michael_heerdegen@web.de
Cc: 27470@debbugs.gnu.org
Subject: bug#27470: 26.0.50; this-command-keys and interactive input
Date: Sat, 22 Jul 2017 11:16:32 +0300 [thread overview]
Message-ID: <83a83wantr.fsf@gnu.org> (raw)
In-Reply-To: <831sq9vphe.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 Jun 2017 10:01:17 +0300)
> Date: Sat, 24 Jun 2017 10:01:17 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 27470@debbugs.gnu.org
>
> > From: Michael Heerdegen <michael_heerdegen@web.de>
> > Date: Sat, 24 Jun 2017 07:58:47 +0200
> >
> > (defun test (arg)
> > (interactive (list (read-from-minibuffer "Input: ")))
> > (message "%S" (cons this-command (this-command-keys)))
> > arg)
> >
> > (global-set-key [f12] #'test)
> >
> > where f12 stands for some random key sequence.
> >
> > Hit f12 and give any input. I get the following message:
> >
> > (test . "^M")
> >
> > I would expect (test . f12).
>
> This happens because read-from-minibuffer enters recursive-edit, and
> we don't preserve this-command-keys across recursive-edit invocations.
>
> This has been Emacs behavior since forever.
>
> The patch below seems to fix this, but I have no idea what it could
> break, given how old this behavior is. So if we are to accept this,
> I'd like to have a few people step forward and run with the change for
> a month or so, to see there are no adverse effects. We've been burnt
> several times lately by changes in keyboard-input stuff that broke
> subtle but very useful features.
Michael, any findings so far? Do you recommend that we push that
change?
Thanks.
next prev parent reply other threads:[~2017-07-22 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 5:58 bug#27470: 26.0.50; this-command-keys and interactive input Michael Heerdegen
2017-06-24 7:01 ` Eli Zaretskii
2017-06-25 5:53 ` Michael Heerdegen
2017-07-22 8:16 ` Eli Zaretskii [this message]
2017-07-23 15:44 ` Michael Heerdegen
2017-07-28 12:41 ` Eli Zaretskii
2017-06-24 13:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a83wantr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27470@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.