From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28156: Emacs quietly munges symlink contents Date: Sun, 20 Aug 2017 22:21:43 +0300 Message-ID: <83a82ucaew.fsf@gnu.org> References: <68b2e6ef-bf0b-ebcf-c577-d296952d593f@cs.ucla.edu> <83pobqcnlf.fsf@gnu.org> <83h8x2ckqn.fsf@gnu.org> <87y3qexfeo.fsf@detlef> <8a526a4a-fd11-06c7-8ad4-bc00a667bcd1@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503256999 19708 195.159.176.226 (20 Aug 2017 19:23:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 20 Aug 2017 19:23:19 +0000 (UTC) Cc: p.stephani2@gmail.com, michael.albinus@gmx.de, 28156@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 20 21:23:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djVoT-0004QU-34 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 21:23:09 +0200 Original-Received: from localhost ([::1]:51298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djVoW-0003Te-Id for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Aug 2017 15:23:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djVoP-0003Ry-Sr for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 15:23:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djVoM-00010m-P8 for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 15:23:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38241) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djVoM-00010i-LC for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 15:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djVoM-0004gV-C1 for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2017 15:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2017 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28156-submit@debbugs.gnu.org id=B28156.150325695417957 (code B ref 28156); Sun, 20 Aug 2017 19:23:02 +0000 Original-Received: (at 28156) by debbugs.gnu.org; 20 Aug 2017 19:22:34 +0000 Original-Received: from localhost ([127.0.0.1]:46922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djVnu-0004fZ-2C for submit@debbugs.gnu.org; Sun, 20 Aug 2017 15:22:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djVns-0004fO-Vd for 28156@debbugs.gnu.org; Sun, 20 Aug 2017 15:22:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djVnk-0000vc-Mh for 28156@debbugs.gnu.org; Sun, 20 Aug 2017 15:22:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djVnk-0000vY-Jb; Sun, 20 Aug 2017 15:22:24 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4407 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1djVni-0002Ug-0R; Sun, 20 Aug 2017 15:22:24 -0400 In-reply-to: <8a526a4a-fd11-06c7-8ad4-bc00a667bcd1@cs.ucla.edu> (message from Paul Eggert on Sun, 20 Aug 2017 11:53:55 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135955 Archived-At: > Cc: Eli Zaretskii , Philipp Stephani , > 28156@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 20 Aug 2017 11:53:55 -0700 > > (shell-command "ln -s '~' symlink") > 0 > (file-symlink-p "symlink") > "~" > (rename-file "symlink" "/tmp/symlink") > nil > (file-symlink-p "/tmp/symlink") > "/home/eggert" If this is the problem, then let's solve it without affecting make-symbolic-link. The problem you show is in file-symlink-p and/or in rename-file. Let's solve it there, and let's solve it without affecting the interactive callers of those functions. > Here, rename-file quietly expands the symlink contents, which is a bug. As far > as I can see, one cannot work around the bug by using Tramp quoting; for > example, (rename-file "/:symlink" "/:/tmp/symlink") does the same thing that > (rename-file "symlink" "/tmp/symlink") does. But AFAIU, file-symlink-p can return a quoted name if its argument is quoted. Doesn't this allow to solve the problem?