From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28571: 25.3; Compile error on macOS Sierra Date: Fri, 29 Sep 2017 10:23:20 +0300 Message-ID: <83a81e9def.fsf@gnu.org> References: <20170923193130.GB6576@breton.holly.idiocy.org> <20170924110658.GA30865@breton.holly.idiocy.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506669850 31925 195.159.176.226 (29 Sep 2017 07:24:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 29 Sep 2017 07:24:10 +0000 (UTC) Cc: 28571@debbugs.gnu.org, p.stephani2@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 29 09:24:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxpeV-0007cF-Ef for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 09:24:03 +0200 Original-Received: from localhost ([::1]:33984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxpec-0003r0-Td for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Sep 2017 03:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxpeX-0003qb-Aq for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxpeU-0000ES-6E for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxpeU-0000ED-2J for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxpeT-0005Er-TC for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2017 03:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2017 07:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28571 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28571-submit@debbugs.gnu.org id=B28571.150666981820105 (code B ref 28571); Fri, 29 Sep 2017 07:24:01 +0000 Original-Received: (at 28571) by debbugs.gnu.org; 29 Sep 2017 07:23:38 +0000 Original-Received: from localhost ([127.0.0.1]:37484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxpe5-0005ED-Tj for submit@debbugs.gnu.org; Fri, 29 Sep 2017 03:23:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxpe4-0005E0-Ie for 28571@debbugs.gnu.org; Fri, 29 Sep 2017 03:23:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxpdw-0008Q0-7g for 28571@debbugs.gnu.org; Fri, 29 Sep 2017 03:23:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxpdw-0008Pw-48; Fri, 29 Sep 2017 03:23:28 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4918 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dxpdv-0001XO-Hf; Fri, 29 Sep 2017 03:23:27 -0400 In-reply-to: <20170924110658.GA30865@breton.holly.idiocy.org> (message from Alan Third on Sun, 24 Sep 2017 12:06:58 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137560 Archived-At: > Date: Sun, 24 Sep 2017 12:06:58 +0100 > From: Alan Third > Cc: 28571@debbugs.gnu.org > > diff --git a/src/conf_post.h b/src/conf_post.h > index febdb8b8bf..dfdb0aa3eb 100644 > --- a/src/conf_post.h > +++ b/src/conf_post.h > @@ -397,3 +397,11 @@ extern int emacs_setenv_TZ (char const *); > #else > # define UNINIT /* empty */ > #endif > + > +/* macOS 10.13 supports futimens and futimesat, older versions don't > + but can appear as though they do. Disable them entirely to avoid > + breaking cross-version builds on macOS. */ > +#ifdef DARWIN_OS > +# undef HAVE_FUTIMENS > +# undef HAVE_FUTIMESAT > +#endif I think it's preferable to have this stuff localized to the configure script. Having the same issue decided in tow different places makes this harder to maintain. Can you add an equivalent test to configure.ac? Thanks.