From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28658: 27.0.50; [PATCH] double/triple clicking in xterm-mouse-mode doesn't respect mouse position Date: Sun, 08 Oct 2017 10:42:20 +0300 Message-ID: <83a812t7ab.fsf@gnu.org> References: <87r2unyh79.fsf@gmail.com> <83zi95x4of.fsf@gnu.org> <87376xxhcg.fsf@gmail.com> <8360bswxx6.fsf@gnu.org> <87d15yd3kf.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507448591 8265 195.159.176.226 (8 Oct 2017 07:43:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 07:43:11 +0000 (UTC) Cc: 28658@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 08 09:43:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16Eq-0001Dp-4C for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 09:43:04 +0200 Original-Received: from localhost ([::1]:52807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16Ex-0006AV-A1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 03:43:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16Er-0006AN-SZ for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 03:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e16Eo-0007kP-Qe for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 03:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46767) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e16Eo-0007kF-N5 for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 03:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e16Eo-0008JO-Dk for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 03:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2017 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28658 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28658-submit@debbugs.gnu.org id=B28658.150744855431915 (code B ref 28658); Sun, 08 Oct 2017 07:43:02 +0000 Original-Received: (at 28658) by debbugs.gnu.org; 8 Oct 2017 07:42:34 +0000 Original-Received: from localhost ([127.0.0.1]:55448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16EM-0008Ih-4U for submit@debbugs.gnu.org; Sun, 08 Oct 2017 03:42:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e16EK-0008IU-Hv for 28658@debbugs.gnu.org; Sun, 08 Oct 2017 03:42:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e16EC-0007Vb-AC for 28658@debbugs.gnu.org; Sun, 08 Oct 2017 03:42:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e16EC-0007VT-6b; Sun, 08 Oct 2017 03:42:24 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3523 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e16EB-0007re-Go; Sun, 08 Oct 2017 03:42:23 -0400 In-reply-to: <87d15yd3kf.fsf@gmail.com> (message from Alex on Sat, 07 Oct 2017 15:57:04 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138068 Archived-At: > From: Alex > Cc: 28658@debbugs.gnu.org > Date: Sat, 07 Oct 2017 15:57:04 -0600 > > > I don't know why the units are 1/8th of a character, perhaps so that a > > user could set the same value for both GUI and TTY frames. In any > > case, dividing the value of double-click-fuzz by 8 before comparing > > with coordinate differences is easy enough, no? > > Yes, I was just confused about the units, but that makes sense. Though > in my GTK Emacs, (frame-char-width) returns 9 instead of 8 for me... Yes, the 8 thing cannot be anything but an approximation. > Anyway, here's the patch: LGTM, thanks. Please mention the bug number in the log message when you push (to the emacs-26 branch).