From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Date: Fri, 08 Dec 2017 16:48:46 +0200 Message-ID: <83a7ytwa0h.fsf@gnu.org> References: <1508054203.3504379.1139170720.0D0E99E9@webmail.messagingengine.com> <59E32D49.4030007@gmx.at> <1508065717.3534312.1139251176.600E646A@webmail.messagingengine.com> <59E350AE.3060005@gmx.at> <1508074073.3557079.1139314312.4BFE5BC2@webmail.messagingengine.com> <83o9p8h2yv.fsf@gnu.org> <1508124120.3709085.1139805520.1F653A1C@webmail.messagingengine.com> <87efq37knc.fsf@gmail.com> <1508130850.3734431.1139876192.21CE8281@webmail.messagingengine.com> <83zi8rf8rx.fsf@gnu.org> <1508200557.2705080.1141019864.6A2B8BD5@webmail.messagingengine.com> <83bml6fqbv.fsf@gnu.org> <1508213954.647567.1141167720.1CC00459@webmail.messagingengine.com> <06925BCF-6C99-423B-AB13-E7331E22B867@gnu.org> <1508224426.2790345.1141279648.61B955E6@webmail.messagingengine.com> <87a7yuey7i.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1512744614 30616 195.159.176.226 (8 Dec 2017 14:50:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Dec 2017 14:50:14 +0000 (UTC) Cc: hello@paulwrankin.com, 28844@debbugs.gnu.org, agrambot@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 08 15:50:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNJyb-0007j0-Gb for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Dec 2017 15:50:09 +0100 Original-Received: from localhost ([::1]:37597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNJyf-000634-QD for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Dec 2017 09:50:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNJyZ-00062x-Qb for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 09:50:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNJyU-00056R-7S for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 09:50:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42880) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNJyU-000569-4Y for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 09:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eNJyT-0000Ys-Tj for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2017 09:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Dec 2017 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28844-submit@debbugs.gnu.org id=B28844.15127445662115 (code B ref 28844); Fri, 08 Dec 2017 14:50:01 +0000 Original-Received: (at 28844) by debbugs.gnu.org; 8 Dec 2017 14:49:26 +0000 Original-Received: from localhost ([127.0.0.1]:51561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNJxu-0000Y3-9d for submit@debbugs.gnu.org; Fri, 08 Dec 2017 09:49:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNJxs-0000Xq-Mr for 28844@debbugs.gnu.org; Fri, 08 Dec 2017 09:49:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNJxm-0004TP-AW for 28844@debbugs.gnu.org; Fri, 08 Dec 2017 09:49:19 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNJxg-0004Qt-JM; Fri, 08 Dec 2017 09:49:12 -0500 Original-Received: from [176.228.60.248] (port=3199 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eNJxf-0004qo-BS; Fri, 08 Dec 2017 09:49:12 -0500 In-reply-to: <87a7yuey7i.fsf@users.sourceforge.net> (message from Noam Postavsky on Thu, 07 Dec 2017 21:43:29 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140816 Archived-At: > From: Noam Postavsky > Cc: Eli Zaretskii , 28844@debbugs.gnu.org, agrambot@gmail.com > Date: Thu, 07 Dec 2017 21:43:29 -0500 > > Paul Rankin writes: > > Whereas my understanding of #20 is that Eli thinks adding a dedicated > hook would be less efficient than using post-command-hook. > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28844#20 Not just less efficient, but also much more problematic for the display code as a whole from the implementation POV. > PS You seem awful quick to jump to Ad Hominem, it makes resolving bug > reports needlessly unpleasant. Well put, thanks. "Unpleasant" indeed. (I might have used stronger words here, but then I'm the one who is being attacked, so I'm probably -- what was that word? ah, yes: "biased".) More to the point, I've offered help, based on my experience in adapting other packages to this new feature. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28844#53 I'm willing to do more, and propose working code, but being unfamiliar with your package, I need some help understanding what is the expected behavior when certain display-related attributes change. For example, what should happen if the user enlarges or makes smaller the default face's font with the likes of "C-x +"? I'm asking this because the effect on the display margins is similar, so I wanted to look what the package does in that case, but it seems to do nothing: the margin dimensions are not changed as I'd expect them to. So I couldn't do more than just suggest a way to solve this. Maybe I missed some setting or knob. I actually think the problem is not so hard and could be solved quite easily, but your help, Paul, is needed to make this happen.