From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: hello@paulwrankin.com, 28844@debbugs.gnu.org, agrambot@gmail.com
Subject: bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook
Date: Fri, 08 Dec 2017 16:48:46 +0200 [thread overview]
Message-ID: <83a7ytwa0h.fsf@gnu.org> (raw)
In-Reply-To: <87a7yuey7i.fsf@users.sourceforge.net> (message from Noam Postavsky on Thu, 07 Dec 2017 21:43:29 -0500)
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, 28844@debbugs.gnu.org, agrambot@gmail.com
> Date: Thu, 07 Dec 2017 21:43:29 -0500
>
> Paul Rankin <hello@paulwrankin.com> writes:
>
> Whereas my understanding of #20 is that Eli thinks adding a dedicated
> hook would be less efficient than using post-command-hook.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28844#20
Not just less efficient, but also much more problematic for the
display code as a whole from the implementation POV.
> PS You seem awful quick to jump to Ad Hominem, it makes resolving bug
> reports needlessly unpleasant.
Well put, thanks. "Unpleasant" indeed. (I might have used stronger
words here, but then I'm the one who is being attacked, so I'm
probably -- what was that word? ah, yes: "biased".)
More to the point, I've offered help, based on my experience in
adapting other packages to this new feature. See
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28844#53
I'm willing to do more, and propose working code, but being unfamiliar
with your package, I need some help understanding what is the expected
behavior when certain display-related attributes change. For example,
what should happen if the user enlarges or makes smaller the default
face's font with the likes of "C-x +"? I'm asking this because the
effect on the display margins is similar, so I wanted to look what the
package does in that case, but it seems to do nothing: the margin
dimensions are not changed as I'd expect them to. So I couldn't do
more than just suggest a way to solve this. Maybe I missed some
setting or knob.
I actually think the problem is not so hard and could be solved quite
easily, but your help, Paul, is needed to make this happen.
next prev parent reply other threads:[~2017-12-08 14:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 7:56 bug#28844: 26.0.90; display-line-numbers-mode should call window-configuration-change-hook Paul Rankin
2017-10-15 9:41 ` martin rudalics
2017-10-15 11:08 ` Paul Rankin
2017-10-15 12:12 ` martin rudalics
2017-10-15 13:27 ` Paul Rankin
2017-10-15 14:59 ` Eli Zaretskii
2017-10-16 3:22 ` Paul Rankin
2017-10-16 4:59 ` Alex
2017-10-16 5:14 ` Paul Rankin
2017-10-16 14:48 ` Eli Zaretskii
2017-10-17 0:35 ` Paul Rankin
2017-10-17 2:41 ` Eli Zaretskii
2017-10-17 4:19 ` Paul Rankin
2017-10-17 5:44 ` Eli Zaretskii
2017-10-17 7:13 ` Paul Rankin
2017-10-17 8:33 ` Eli Zaretskii
2017-10-20 9:42 ` Eli Zaretskii
2017-12-08 2:43 ` Noam Postavsky
2017-12-08 14:48 ` Eli Zaretskii [this message]
2017-12-09 15:30 ` Paul Rankin
2017-12-09 16:01 ` Eli Zaretskii
2017-10-15 14:47 ` Eli Zaretskii
2017-10-16 7:41 ` martin rudalics
2017-10-22 7:20 ` Paul Rankin
2017-10-22 14:27 ` Eli Zaretskii
2017-12-08 2:14 ` Paul Rankin
2017-12-08 15:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7ytwa0h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=28844@debbugs.gnu.org \
--cc=agrambot@gmail.com \
--cc=hello@paulwrankin.com \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.