From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Date: Tue, 19 Dec 2017 18:15:45 +0200 Message-ID: <83a7yepuby.fsf@gnu.org> References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1513700057 6342 195.159.176.226 (19 Dec 2017 16:14:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Dec 2017 16:14:17 +0000 (UTC) Cc: 20871@debbugs.gnu.org To: Marcin Borkowski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 19 17:14:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRKWz-0001Pb-38 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 17:14:13 +0100 Original-Received: from localhost ([::1]:52476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKYx-0001JY-CB for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Dec 2017 11:16:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKYn-0001IW-Ta for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 11:16:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRKYk-0002df-5q for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 11:16:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRKYk-0002dK-1d for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 11:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRKYj-0006nu-Ru for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2017 11:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2017 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20871-submit@debbugs.gnu.org id=B20871.151370014526127 (code B ref 20871); Tue, 19 Dec 2017 16:16:01 +0000 Original-Received: (at 20871) by debbugs.gnu.org; 19 Dec 2017 16:15:45 +0000 Original-Received: from localhost ([127.0.0.1]:42496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRKYT-0006nL-AZ for submit@debbugs.gnu.org; Tue, 19 Dec 2017 11:15:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRKYS-0006nA-5V for 20871@debbugs.gnu.org; Tue, 19 Dec 2017 11:15:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRKYJ-00029F-CY for 20871@debbugs.gnu.org; Tue, 19 Dec 2017 11:15:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKYJ-000298-77; Tue, 19 Dec 2017 11:15:35 -0500 Original-Received: from [176.228.60.248] (port=2201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eRKYI-0000eD-Ka; Tue, 19 Dec 2017 11:15:35 -0500 In-reply-to: <87r2rr7xii.fsf@mbork.pl> (message from Marcin Borkowski on Tue, 19 Dec 2017 12:44:21 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141255 Archived-At: > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Tue, 19 Dec 2017 12:44:21 +0100 > > >> I took a look. It looks reasonable, but I think it will also need to > >> be mentioned in the Emacs User manual, node "Fill Commands". In > >> addition, could you write a couple of tests for this feature? > > > > OK, I'll look into it and get back here. > > So I did take a look. The mention in the manual is already there, > I forgot I did that back then. Right, sorry I missed that somehow. > Where should I put the tests? > I expected something in e.g. test/lisp/textmodes/fill.el, but there's > nothing like that there. If the file doesn't exist, create it. > Also, should I test only my function, or filling with it, or both? I think filling with your function is the most important thing to test. Thanks.