From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used Date: Tue, 23 Jan 2018 21:30:17 +0200 Message-ID: <83a7x4nzjq.fsf@gnu.org> References: <87a7x5ejsu.fsf@gmail.com> <878tcpfmnz.fsf@tcd.ie> <87607s62zt.fsf@gmail.com> <874lnc62sj.fsf@gmail.com> <877es8xv8m.fsf@tcd.ie> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516735756 31358 195.159.176.226 (23 Jan 2018 19:29:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 19:29:16 +0000 (UTC) Cc: alex.branham@gmail.com, 30213@debbugs.gnu.org To: "Basil L. Contovounesios" , Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 20:29:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee4Fm-0007Yz-Eh for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 20:29:06 +0100 Original-Received: from localhost ([::1]:48215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee4Hm-0007Td-TO for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 14:31:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee4Hh-0007TR-B3 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee4He-0000z7-8f for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60249) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee4He-0000yM-5G for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee4Hd-0006ZC-Tm for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30213-submit@debbugs.gnu.org id=B30213.151673583825209 (code B ref 30213); Tue, 23 Jan 2018 19:31:01 +0000 Original-Received: (at 30213) by debbugs.gnu.org; 23 Jan 2018 19:30:38 +0000 Original-Received: from localhost ([127.0.0.1]:39913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee4HG-0006YX-FH for submit@debbugs.gnu.org; Tue, 23 Jan 2018 14:30:38 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee4HE-0006YH-9B for 30213@debbugs.gnu.org; Tue, 23 Jan 2018 14:30:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee4H5-0000ZO-Ue for 30213@debbugs.gnu.org; Tue, 23 Jan 2018 14:30:31 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee4H5-0000Z7-Mc; Tue, 23 Jan 2018 14:30:27 -0500 Original-Received: from [176.228.60.248] (port=1753 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ee4H5-0001vH-3c; Tue, 23 Jan 2018 14:30:27 -0500 In-reply-to: <877es8xv8m.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142445 Archived-At: > From: "Basil L. Contovounesios" > Date: Tue, 23 Jan 2018 18:53:13 +0000 > Cc: 30213@debbugs.gnu.org > > * lisp/simple.el (shell-command): Display async command buffer on > process output for every invocation, not just the first. (bug#30213) > --- > lisp/simple.el | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lisp/simple.el b/lisp/simple.el > index 3ac6b86381..20e22bf98f 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -3551,9 +3551,7 @@ shell-command > (add-function :before (process-filter proc) > (lambda (process _string) > (let ((buf (process-buffer process))) > - (when (and (zerop (buffer-size buf)) > - (string= (buffer-name buf) > - bname)) > + (when (string= (buffer-name buf) bname) > (display-buffer buf)))))))) > ;; Otherwise, command is executed synchronously. > (shell-command-on-region (point) (point) command Looks like you are removing the feature we just introduced in Emacs 26, see commit 85512e7: it shows the shell buffer only if there is some output there. Or am I missing something?