From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>,
Reuben Thomas <rrt@sc3d.org>
Cc: alex.branham@gmail.com, 30213@debbugs.gnu.org
Subject: bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used
Date: Tue, 23 Jan 2018 21:30:17 +0200 [thread overview]
Message-ID: <83a7x4nzjq.fsf@gnu.org> (raw)
In-Reply-To: <877es8xv8m.fsf@tcd.ie> (contovob@tcd.ie)
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Tue, 23 Jan 2018 18:53:13 +0000
> Cc: 30213@debbugs.gnu.org
>
> * lisp/simple.el (shell-command): Display async command buffer on
> process output for every invocation, not just the first. (bug#30213)
> ---
> lisp/simple.el | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index 3ac6b86381..20e22bf98f 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -3551,9 +3551,7 @@ shell-command
> (add-function :before (process-filter proc)
> (lambda (process _string)
> (let ((buf (process-buffer process)))
> - (when (and (zerop (buffer-size buf))
> - (string= (buffer-name buf)
> - bname))
> + (when (string= (buffer-name buf) bname)
> (display-buffer buf))))))))
> ;; Otherwise, command is executed synchronously.
> (shell-command-on-region (point) (point) command
Looks like you are removing the feature we just introduced in Emacs
26, see commit 85512e7: it shows the shell buffer only if there is
some output there. Or am I missing something?
next prev parent reply other threads:[~2018-01-23 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 20:10 bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used Alex Branham
2018-01-23 0:23 ` Basil L. Contovounesios
2018-01-23 14:53 ` Alex Branham
2018-01-23 14:57 ` Alex Branham
2018-01-23 18:53 ` Basil L. Contovounesios
2018-01-23 19:07 ` Alex Branham
2018-01-23 19:30 ` Eli Zaretskii [this message]
2018-01-23 22:44 ` Basil L. Contovounesios
2018-02-03 21:31 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7x4nzjq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30213@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=contovob@tcd.ie \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.