From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Identifying the face between STRETCH and right fringe. Date: Wed, 28 Nov 2018 11:45:05 +0200 Message-ID: <83a7ltfsda.fsf@gnu.org> References: <83h8gbis2d.fsf@gnu.org> <83zhu0f6tt.fsf@gnu.org> <83sgzrgb1f.fsf@gnu.org> <83r2fbg5bq.fsf@gnu.org> <83lg5jfs9o.fsf@gnu.org> <83a7luhnid.fsf@gnu.org> <838t1ehi6v.fsf@gnu.org> <831s76gxkq.fsf@gnu.org> <83h8g1fzdr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1543398178 5671 195.159.176.226 (28 Nov 2018 09:42:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Nov 2018 09:42:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 28 10:42:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRwMu-0001Kf-IA for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2018 10:42:52 +0100 Original-Received: from localhost ([::1]:46827 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRwP1-0002Vv-2G for ged-emacs-devel@m.gmane.org; Wed, 28 Nov 2018 04:45:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRwOw-0002Vf-7K for emacs-devel@gnu.org; Wed, 28 Nov 2018 04:44:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRwOt-0003NP-1g for emacs-devel@gnu.org; Wed, 28 Nov 2018 04:44:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRwOs-0003NJ-VE; Wed, 28 Nov 2018 04:44:54 -0500 Original-Received: from [176.228.60.248] (port=1301 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRwOs-0002mi-JH; Wed, 28 Nov 2018 04:44:54 -0500 In-reply-to: (message from Robert Pluim on Wed, 28 Nov 2018 09:36:53 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231480 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Wed, 28 Nov 2018 09:36:53 +0100 > > Eli Zaretskii writes: > > >> From: Robert Pluim > >> Cc: emacs-devel@gnu.org > >> Date: Tue, 27 Nov 2018 20:14:14 +0100 > >> > >> >> > Why does NS use indices here, and not RGBA values? > >> >> > >> >> Probably because NS doesnʼt really use the RGBA values directly at > >> >> all, but uses the indices all the time. > >> > > >> > So where does the RGBA value in FRAME_BACKGROUND_PIXEL come from? > > > > Can you answer this question? > > Itʼs set by the NS version of x_set_background_color, so itʼs correct, > just not the same format as the face background colour. So they call ns_lisp_to_color once and store the result? I still wonder why they don't do this with other face colors. Is ns_lisp_to_color expensive or something? > >> - && face->background == FRAME_BACKGROUND_PIXEL (f) > >> + && FACE_COLOR_TO_PIXEL(face->background, f) == FRAME_BACKGROUND_PIXEL (f) > > ^ > > Please leave one space between the macro name and the opening paren. > > Fixed (plus a missing space at the end of a comment sentence). Thanks.