From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line Date: Sun, 17 Mar 2019 22:40:02 +0200 Message-ID: <83a7htw7z1.fsf@gnu.org> References: <20190316015314.2335-1-Hi-Angel@yandex.ru> <20190316015314.2335-2-Hi-Angel@yandex.ru> <1552854450.16839.2@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255796"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Konstantin Kharlamov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 17 21:56:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5cpE-0014T9-Nw for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 21:56:08 +0100 Original-Received: from localhost ([127.0.0.1]:60110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5cpD-0005XF-O3 for ged-emacs-devel@m.gmane.org; Sun, 17 Mar 2019 16:56:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5cmZ-00045M-5q for emacs-devel@gnu.org; Sun, 17 Mar 2019 16:53:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5cZs-0006ZG-4e; Sun, 17 Mar 2019 16:40:18 -0400 Original-Received: from [176.228.60.248] (port=4754 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h5cZp-0002Mf-HV; Sun, 17 Mar 2019 16:40:14 -0400 In-reply-to: <1552854450.16839.2@yandex.ru> (message from Konstantin Kharlamov on Sun, 17 Mar 2019 23:27:30 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234301 Archived-At: > Date: Sun, 17 Mar 2019 23:27:30 +0300 > From: Konstantin Kharlamov > Cc: emacs-devel@gnu.org > > >> Okay, so: ^M appears in selective-display-mode only in the end of a > >> line. > > > > No, ^M _replaces_ newline characters, so what was previously several > > lines is now a single long line. > > Sure, but after the patch we don't match the whole line anymore. We > only match the tag. We don't care if it's at the beginning of the line > or in the middle of it. We only look for the tag. So we don't care if > line has a newline character or ^M. But that's incorrect: a tag in a tags table always begins at the beginning of a line, so it must be a search anchored at the beginning of the line. And in selective-display mode ^M counts as the beginning of a line.