From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37006: 27.0.50; garbage collection not happening after 26de2d42 Date: Mon, 12 Aug 2019 05:31:18 +0300 Message-ID: <83a7cft8qx.fsf@gnu.org> References: <5075406D-6DB8-4560-BB64-7198526FCF9F@acm.org> <83h86nu0pq.fsf@gnu.org> <86pnlbphus.fsf@phe.ftfl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95295"; mail-complaints-to="usenet@blaine.gmane.org" Cc: mattiase@acm.org, eggert@cs.ucla.edu, 37006@debbugs.gnu.org To: Joseph Mingrone Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 12 04:32:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hx080-000OdG-Pj for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Aug 2019 04:32:08 +0200 Original-Received: from localhost ([::1]:42514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hx07z-0001Y8-RM for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Aug 2019 22:32:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60734) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hx07v-0001Y0-85 for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 22:32:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hx07u-0004WZ-8I for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 22:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hx07u-0004WV-5B for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 22:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hx07t-0000f0-Vf for bug-gnu-emacs@gnu.org; Sun, 11 Aug 2019 22:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Aug 2019 02:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37006 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37006-submit@debbugs.gnu.org id=B37006.15655771041705 (code B ref 37006); Mon, 12 Aug 2019 02:32:01 +0000 Original-Received: (at 37006) by debbugs.gnu.org; 12 Aug 2019 02:31:44 +0000 Original-Received: from localhost ([127.0.0.1]:46003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hx07b-0000R0-QV for submit@debbugs.gnu.org; Sun, 11 Aug 2019 22:31:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hx07Z-0000Kq-Lg for 37006@debbugs.gnu.org; Sun, 11 Aug 2019 22:31:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hx07T-0004R8-HS; Sun, 11 Aug 2019 22:31:35 -0400 Original-Received: from [176.228.60.248] (port=4439 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hx07S-0000TZ-Cq; Sun, 11 Aug 2019 22:31:35 -0400 In-reply-to: <86pnlbphus.fsf@phe.ftfl.ca> (message from Joseph Mingrone on Sun, 11 Aug 2019 17:28:11 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164909 Archived-At: > From: Joseph Mingrone > Cc: Mattias Engdegård , > eggert@cs.ucla.edu > Date: Sun, 11 Aug 2019 17:28:11 -0300 > > > Thanks, I fixed this slightly differently, in a way that makes it more > > explicit why we need a non-trivial code there. Joseph, please see if > > the latest master fixes the problem. > > > (IMNSHO, this issue makes INT_ADD_WRAPV and friends unsafe; at the > > very least this caveat should be prominently documented in Gnulib's > > intprops.h.) > > I have been running 94644d8 for the past hour or so and resident memory for the Emacs process is up over 1300 MB. Also with `garbage-collection-messages' set to t, I do not see any messages about garbage collection. Are you saying that the fix didn't solve the problem for you? I definitely saw a lot of GC messages after the fix where I didn't before. For example, if you visit xdisp.c from the Emacs sources and page through it with C-v, don't you see a lot of GC messages? > I should also add that after my initial report, running 26de2d42, I did eventually start seeing garbage collection messages and the memory usage stopped increasing. Something must have triggered garbage collection to start again. After a lot of consing, the GC would come back for a while, until it would be effectively disabled again by some opportune code path. If you see no GC messages for a long time, attach a debugger and look at the value of consing_until_gc. If its value is huge, around LONG_MAX, the problem is still not completely solved.