From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37153: 26.1; some png images scrambled Date: Sun, 25 Aug 2019 21:56:26 +0300 Message-ID: <83a7bxgjl1.fsf@gnu.org> References: <5b006777-5e97-a641-6f93-83a437ca9ca7@cs.ucla.edu> <44134.15891.158963.23904@gargle.gargle.HOWL> <9c4c68ebe20cbcc44763be8e72bd25eb.squirrel@weber.math.s.chiba-u.ac.jp> <5136.20784.40920.23906@gargle.gargle.HOWL> <4a893dc7-659a-be76-01d3-3f0a4de57ba4@cs.ucla.edu> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="189531"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37153@debbugs.gnu.org, winkler@gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 20:57:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1xhU-000nA3-R9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 20:57:16 +0200 Original-Received: from localhost ([::1]:46056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1xhT-000534-2k for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 14:57:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60578) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1xhH-0004yu-5Y for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 14:57:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1xhG-00014x-3k for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 14:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1xhG-00014p-0W for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 14:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1xhF-00088V-UR for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 14:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37153 X-GNU-PR-Package: emacs Original-Received: via spool by 37153-submit@debbugs.gnu.org id=B37153.156675940631254 (code B ref 37153); Sun, 25 Aug 2019 18:57:01 +0000 Original-Received: (at 37153) by debbugs.gnu.org; 25 Aug 2019 18:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:45107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1xgz-000881-Nb for submit@debbugs.gnu.org; Sun, 25 Aug 2019 14:56:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1xgw-00087n-GO for 37153@debbugs.gnu.org; Sun, 25 Aug 2019 14:56:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i1xgp-0000wo-UX; Sun, 25 Aug 2019 14:56:35 -0400 Original-Received: from [176.228.60.248] (port=4757 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i1xgn-0007pX-Tg; Sun, 25 Aug 2019 14:56:34 -0400 In-reply-to: <4a893dc7-659a-be76-01d3-3f0a4de57ba4@cs.ucla.edu> (message from Paul Eggert on Sun, 25 Aug 2019 11:38:07 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165853 Archived-At: > From: Paul Eggert > Date: Sun, 25 Aug 2019 11:38:07 -0700 > Cc: 37153@debbugs.gnu.org > > > It seems to be necessary to look into the tRNS chunk data for paletted > > images. Again, W32 would need some more work. > > Thanks, I confirmed that this fixes the misdisplay for me as well. I attempted > to port it to w32 (as well as to unusual libpng builds that do not define > PNG_tRNS_SUPPORTED) and installed the attached into master. Thanks, this builds on MS-Windows, but the display of that PNG image is still incorrect. My guess is that some changes are needed in image_create_x_image_and_pixmap_1, where there's a separate implementation for HAVE_NTGUI. But I have no idea what changes are needed there.